Skip to content

Pullquote Block #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkaz merged 10 commits into from
May 5, 2017
Merged

Pullquote Block #607

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a3a03be
Pullquote Block - initial block
mkaz May 3, 2017
0017e3a
Allow classnames to be specified for icon
mkaz May 2, 2017
056cd7c
Merge
mkaz May 3, 2017
75df7b6
Pull back the design a little bit ;)
jasmussen May 3, 2017
31a51ae
Merge
mkaz May 3, 2017
ab81b8e
Remove unused attr import
mkaz May 3, 2017
ff87c9f
Remove additional classnames from control - not needed yet
mkaz May 4, 2017
f05af0d
Add i18n for placeholders, use ellipsis
mkaz May 4, 2017
98197c1
Add inline to Editable component
mkaz May 5, 2017
5996a31
Add check for citation length
mkaz May 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pull back the design a little bit ;) 
Revert to a more minimalist design for now.
  • Loading branch information
@jasmussen @mkaz
jasmussen authored and mkaz committed May 4, 2017
commit 75df7b6c6155af54501b886e009a452261cfb71f
4 changes: 2 additions & 2 deletions blocks/library/pullquote/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ registerBlock( 'core/pullquote', {
return (
<blockquote className={ `blocks-pullquote blocks-pullquote-bg-${ bg } blocks-pullquote-style-${ style }` }>
<Editable
value={ value || 'Write Quote' }
value={ value || 'Write quote...' }
Copy link
Member

@aduth aduth May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Should be translated via wp.i18n.__
  2. Should use ellipsis character for semantic meaning over three dots (…)

onChange={
( nextValue ) => setAttributes( {
value: nextValue
Expand All @@ -84,7 +84,7 @@ registerBlock( 'core/pullquote', {
{ ( citation || !! focus ) && (
<footer>
<Editable
value={ citation || 'Write Citation' }
value={ citation || 'Write citation...' }
onChange={
( nextCitation ) => setAttributes( {
citation: nextCitation
Expand Down
72 changes: 10 additions & 62 deletions blocks/library/pullquote/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,75 +1,23 @@
$c1: #29A188;
$c2: #FCB740;
$c3: #F03D56;

.blocks-pullquote {

color: $white;
background-color: inherit;
box-shadow: none;

// replace with full-width, 700px = editor size, 160px = sidebar
width: calc(100vw - 160px);
margin-top: 0;
margin-bottom: 0;
margin-left: calc((700px - 100vw)/2 + 60px ); // not quite sure why 60px works
margin-right: calc((700px - 100vw)/2 );


padding: 4em 25%;
color: $light-gray-900;
padding: 2em;
text-align: center;

footer {
color: $black;
margin-left: 1.3em;
color: $dark-gray-900;
position: relative;

p {
font-size: 22px;
font-style: normal;
}

}
}

.blocks-pullquote-bg-1 {
background-color: $c1;
}

.blocks-pullquote-bg-2 {
background-color: $c2;
}

.blocks-pullquote-bg-3 {
background-color: $c3;
}

.editor-visual-editor .blocks-pullquote-style-1 {
& > .blocks-editable p {
font-family: Impact, Haettenschweiler, 'Arial Narrow Bold', sans-serif;
font-size: 36px;
font-weight: 700;
line-height: 38px;
footer p {
font-size: 16px;
font-family: $default-font;
}
}

.editor-visual-editor .blocks-pullquote-style-2 {
.editor-visual-editor .blocks-pullquote-style-1 {
& > .blocks-editable p {
font-size: 36px;
font-style: italic;
line-height: 38px;
font-family: $default-font;
font-size: 48px;
font-weight: 900;
}
}

// color icon controls
.editor-toolbar__control.editor-button.color1 {
color: $c1;
}

.editor-toolbar__control.editor-button.color2 {
color: $c2;
}

.editor-toolbar__control.editor-button.color3 {
color: $c3;
}