-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Pattern overrides: use block binding editing API #60721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
78f9601
Pattern overrides: use block binding editing API
ellatrix 17b31b8
Update only the needed attributes with bindings
SantosGuillamot 63c6b6d
Keep blocks as normal when editing pattern
SantosGuillamot 46063db
Use inner blocks for set edit mode
SantosGuillamot f1f78ae
Change indiviual reset logic
SantosGuillamot 8121723
Move variable after early return
SantosGuillamot ec4daec
Add inline comment for bindings setAttributes
SantosGuillamot 35aa0ab
Change variable to isOverriden
SantosGuillamot a71ba38
Change missing isOverriden
SantosGuillamot 29afc1f
Fix detaching of synced patterns
SantosGuillamot 31bf94c
Sync values of bound attributes
SantosGuillamot 6c60eb3
Adapt synced pattern tests
SantosGuillamot 49b062a
Use overriden values when detaching pattern
SantosGuillamot 766a762
Adapt pattern-overrides tests
SantosGuillamot 49286e1
Add workaround for pattern overrides
SantosGuillamot ef29ab3
Don't update non-bound attributes when using patterns
SantosGuillamot ba8b618
Add test for blocks with a shared name
SantosGuillamot e695fb4
Support button rel in bindings editor logic
SantosGuillamot d9d9fd6
Solve undo/redo issues
SantosGuillamot 4a4465f
Stop using syncDerivedUpdates
SantosGuillamot 1101667
Ensure change is marked as persistent in pattern overrides
SantosGuillamot a95749f
Try to solve undo/redo issues
SantosGuillamot e2a1b8a
Manage undefined attrs in pattern overrides
SantosGuillamot 9d444a3
Remove `content` pattern property if empty
SantosGuillamot e28da53
Remove pattern-overrides specific code from `withBlockBindingSupport`…
talldan ae534d8
Fix persistent issues with setValues API
ellatrix 4ec7315
Fall back to ''
ellatrix 3a7311d
Make sure any previous changes are persisted before resetting.
ellatrix e013f6d
Add undo/redo test for resetting
kevin940726 950aab9
Fix test... 🤦
kevin940726 d99ecb7
Fix remaining undo test
ellatrix 9ec9bba
Fix individual reset
ellatrix 7d72a34
Add test for undoing loses the focus
kevin940726 4ebdb09
Fix reset button test
ellatrix 44b51dd
Simplify pattern synced blocks test
SantosGuillamot 5975f74
Remove focus test
SantosGuillamot 10fa4e8
Use getBlockParentsByBlockName
SantosGuillamot 3cfdd44
Add early return if blockName doesn't exist
SantosGuillamot 8c5f574
Add comment for undefined values
SantosGuillamot 3866446
Remove comment typo
SantosGuillamot 33bfb86
Remove unnecessary includeHidden from tests
SantosGuillamot d80aba7
Check the frontend in patterns test
SantosGuillamot 6b97321
Check frontend in updated pattern
SantosGuillamot c122b79
Stop using `getPatternRecord`
SantosGuillamot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.