Skip to content

Fix: Don't allow selection of template parts that the user doesn't have the privileges to edit #60812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabiankaegy wants to merge 2 commits into from
Closed

Fix: Don't allow selection of template parts that the user doesn't have the privileges to edit #60812

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c4ca76
fix only allow users to select template part block if they can edit t…
fabiankaegy Apr 3, 2024
b57a682
fix test case
fabiankaegy Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix test case
  • Loading branch information
@fabiankaegy
fabiankaegy committed Apr 17, 2024
commit b57a6821a3b5dbb65fe415500aaf29630357a180
60 changes: 35 additions & 25 deletions packages/editor/src/components/provider/test/disable-non-page-content-blocks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,34 +40,44 @@ describe( 'DisableNonPageContentBlocks', () => {
type: 'UNSET_BLOCK_EDITING_MODE',
} ) );

const registry = createRegistry( {
'core/block-editor': {
reducer: () => {},
selectors: {
getBlocksByName( state, blockNames ) {
return Object.keys( testBlocks ).filter( ( clientId ) =>
blockNames.includes( testBlocks[ clientId ] )
);
},
getBlockParents( state, clientId ) {
return clientId.slice( 0, -1 ).split( '' );
},
getBlockName( state, clientId ) {
return testBlocks[ clientId ];
},
getBlockOrder( state, rootClientId ) {
return Object.keys( testBlocks ).filter(
( clientId ) =>
clientId.startsWith( rootClientId ) &&
clientId !== rootClientId
);
},
const registry = createRegistry();

registry.registerStore( 'core/block-editor', {
reducer: () => {},
selectors: {
getBlocksByName( state, blockNames ) {
return Object.keys( testBlocks ).filter( ( clientId ) =>
blockNames.includes( testBlocks[ clientId ] )
);
},
getBlockParents( state, clientId ) {
return clientId.slice( 0, -1 ).split( '' );
},
getBlockName( state, clientId ) {
return testBlocks[ clientId ];
},
getBlockOrder( state, rootClientId ) {
return Object.keys( testBlocks ).filter(
( clientId ) =>
clientId.startsWith( rootClientId ) &&
clientId !== rootClientId
);
},
actions: {
setBlockEditingMode,
unsetBlockEditingMode,
},
actions: {
setBlockEditingMode,
unsetBlockEditingMode,
},
} );

registry.registerStore( 'core', {
reducer: () => {},
selectors: {
canUser() {
return true;
},
},
actions: {},
} );

const { unmount } = render(
Expand Down