Skip to content

Remove block-editor package usage from components #60999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirreal merged 8 commits into from
Apr 24, 2024
Merged

Remove block-editor package usage from components #60999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d00e9c8
Exclude all components stories from tsconfig
sirreal Apr 23, 2024
13b132a
Remove unused import
sirreal Apr 23, 2024
04a4ed5
Add stories tsconfig
sirreal Apr 23, 2024
24547aa
Remove redundant tsconfig from components
sirreal Apr 23, 2024
b743fbb
simplify config
sirreal Apr 23, 2024
662d589
Remove unused story for useCx
mirka Apr 23, 2024
ef95a6a
Revert "Add stories tsconfig"
sirreal Apr 24, 2024
a7b04df
Revert "Exclude all components stories from tsconfig"
sirreal Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/components/src/popover/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import type { StoryFn, Meta } from '@storybook/react';
* WordPress dependencies
*/
import { useState, useRef, useEffect } from '@wordpress/element';
// @ts-expect-error The `@wordpress/block-editor` is not typed
import { __unstableIframe as Iframe } from '@wordpress/block-editor';

/**
* Internal dependencies
Expand Down
157 changes: 0 additions & 157 deletions packages/components/src/utils/hooks/stories/use-cx.js
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions packages/components/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
],
// TODO: Remove `skipLibCheck` after resolving duplicate declaration of the `process` variable
// between `@types/webpack-env` (from @storybook packages) and `gutenberg-env`.
"skipLibCheck": true,
"strictNullChecks": true
Copy link
Member

@mirka mirka Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for posterity: strictNullChecks was redundant here because it's included in the "strict": true of the base config.

"skipLibCheck": true
},
"references": [
{ "path": "../a11y" },
Expand Down