Skip to content

DataViews: Type the ViewList component #61246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 4 commits into from
May 6, 2024
Merged

DataViews: Type the ViewList component #61246

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b462b9
DataViews: Type the ViewList component
youknowriad Apr 30, 2024
bbe9879
Update tsconfig
youknowriad May 1, 2024
538017b
Avoid ts-ignore
youknowriad May 6, 2024
e9f311e
Prefer interface over type
youknowriad May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Prefer interface over type
  • Loading branch information
@youknowriad
youknowriad committed May 6, 2024
commit e9f311e24f225a2cdf88661781a0a09545bb6278
8 changes: 4 additions & 4 deletions packages/dataviews/src/view-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import type {
ViewList as ViewListType,
} from './types';

type ListViewProps = {
interface ListViewProps {
view: ViewListType;
fields: NormalizedField[];
data: Data;
Expand All @@ -37,17 +37,17 @@ type ListViewProps = {
onSelectionChange: ( selection: Item[] ) => void;
selection: Item[];
id: string;
};
}

type ListViewItemProps = {
interface ListViewItemProps {
id: string;
item: Item;
isSelected: boolean;
onSelect: ( item: Item ) => void;
mediaField?: NormalizedField;
primaryField?: NormalizedField;
visibleFields: NormalizedField[];
};
}

const {
useCompositeStoreV2: useCompositeStore,
Expand Down