Skip to content

Performance Tests: Improve collection and reporting #61450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 7 commits into from
May 13, 2024
Merged

Performance Tests: Improve collection and reporting #61450

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2a30df3
Collect Server-Timing metrics
swissspidy May 7, 2024
a9f7c31
Generate workflow summary
swissspidy May 7, 2024
8df8dd2
Use for loop
swissspidy May 7, 2024
ff3bca3
Remove comment
swissspidy May 7, 2024
d366d2e
Expand allowlist
swissspidy May 7, 2024
b58fd12
Improve formatting
swissspidy May 7, 2024
4ac97f1
Merge branch 'trunk' into try/expand-performance-tests
swissspidy May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve formatting
  • Loading branch information
@swissspidy
swissspidy committed May 7, 2024
commit b58fd12cc01ce4fc50214ab2d315ac8a3741bae1
23 changes: 22 additions & 1 deletion bin/plugin/commands/performance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,24 @@ function formatAsMarkdownTable( rows ) {
return result;
}

/**
* Nicely formats a given value.
*
* @param {string} metric Metric.
* @param {number} value
*/
function formatValue( metric, value ) {
if ( 'wpMemoryUsage' === metric ) {
return `${ ( value / Math.pow( 10, 6 ) ).toFixed( 2 ) } MB`;
}

if ( 'wpDbQueries' === metric ) {
return value.toString();
}

return `${ value } ms`;
}

/**
* Runs the performances tests on an array of branches and output the result.
*
Expand Down Expand Up @@ -495,7 +513,10 @@ async function runPerformanceTests( branches, options ) {
) ) {
for ( const [ metric, value ] of Object.entries( metrics ) ) {
invertedResult[ metric ] = invertedResult[ metric ] || {};
invertedResult[ metric ][ branch ] = `${ value } ms`;
invertedResult[ metric ][ branch ] = formatValue(
metric,
value
);
}
}

Expand Down