Skip to content

Conversation

@saulirajala
Copy link

@saulirajala saulirajala commented May 8, 2024

What?

Do not add add <ul> -wrapper to page-list block, when the block is used inside of navigation-block.

Why?

Fix for #60500. When you use page-list -block as inner block of navigation block, there will be invalid html code (<ul><ul><li></li></ul></ul> -structure) in the frontend.

Testing Instructions

  1. Check Playground PR Preview
  2. Inspect the navigation in header. It has <ul><li></li></ul> -structure, which is valid html

Screenshot 2024-05-08 at 11 00 50

Fix issue with double ul-elements. Fix WordPress#60500
@saulirajala saulirajala requested a review from ajitbohra as a code owner May 8, 2024 07:30
@github-actions
Copy link

github-actions bot commented May 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: saulirajala <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label May 8, 2024
@github-actions
Copy link

github-actions bot commented May 8, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @saulirajala! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions
Copy link

github-actions bot commented May 8, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: First-time Contributor.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@saulirajala
Copy link
Author

Actually this will introduce another issue: the ul.wp-block-page-list -element&class is missing from DOM, which is not good.

The original issue probably needs to be solved in navigation -block. So closing this pr

@saulirajala saulirajala closed this May 8, 2024
Copy link
Member

@SirLouen SirLouen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saulirajala I've been rethinking your proposal and its true, it might need to be solved straight on navigation block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants