DataViews: Type the BulkActions component #61666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
May 14, 2024
| return action.supportsBulk && action.isEligible( item ); | ||
| return ( | ||
| action.supportsBulk && | ||
| ( ! action.isEligible || action.isEligible( item ) ) |
Contributor
Author
There was a problem hiding this comment.
isEligible is not mandatory in actions (you can check that in other components). So typing this component actually highlights that this case was not being considered. So this should be a fix.
youknowriad
commented
May 14, 2024
| hideModalHeader: true, | ||
| supportsBulk: true, | ||
| RenderModal: ( { items, closeModal, onPerform } ) => { | ||
| RenderModal: ( { items, closeModal, onActionPerformed } ) => { |
Contributor
Author
There was a problem hiding this comment.
If I'm not wrong, this was a bug too. I see that all actions everywhere in dataviews use onActionPerformed prop and not onPerform. This is also something that I found thanks to the types.
Member
There was a problem hiding this comment.
Yes, it seems it was a bug.
|
Size Change: -2 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 65c14fd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9085038406
|
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
It looks good and the addition of types caught two issues 👍
| return action.supportsBulk && action.isEligible( item ); | ||
| return ( | ||
| action.supportsBulk && | ||
| ( ! action.isEligible || action.isEligible( item ) ) |
| hideModalHeader: true, | ||
| supportsBulk: true, | ||
| RenderModal: ( { items, closeModal, onPerform } ) => { | ||
| RenderModal: ( { items, closeModal, onActionPerformed } ) => { |
Member
There was a problem hiding this comment.
Yes, it seems it was a bug.
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
It looks good and the addition of types caught two issues 👍
jorgefilipecosta
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
Follow-up to #61185
What?
The DataViews package is a types heavy package. There's a lot of structures that need to be documented properly. So this continues the effort to add explicit types to the package. This PR focuses on typing the BulkActions component.
Testing instructions
There's no functional change, it's essentially a code quality + documentation change.