-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add defaultSpacingSizes option (theme.json v3) #61842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
343fafc
Refactor magic number to constant
ajlende 21cf2ba
Add defaultSpacingSizes option
ajlende 119bff1
Add migration docs
ajlende f19da26
Update API docs
ajlende 9ede3bb
Refactor to not need constants
ajlende b3f304b
Update PHPUnit tests
ajlende 666fc4e
Fix PHP lint
ajlende 0301b49
Fix PHP lint
ajlende f5010ef
Make sure all spread vairables cannot be null
ajlende 6fbb99f
Code cleanup
ajlende b1126b7
Add backport-changelog
ajlende 8a5f339
Prevent spacingSizes from entirely replacing presets generated from s…
ajlende 73d63a7
Be more specific about limits in the schema
ajlende ada604b
Move comment
ajlende 882f02e
Increase limit to 10
ajlende 3415b6a
Fix merging of origins
ajlende 8529aef
Use old when checking for existance in migration
ajlende 5d2762a
Fix copy/paste mistake
ajlende 8093334
Fix some v2 backcompat
ajlende 59eaac3
Don't bother with skipping pre-generation on v2 for filters
ajlende 1aafb16
Switch back to numbers for labels in the range control
ajlende 21e6de7
Deprecate set_spacing_sizes
ajlende d42932b
Remove comment
ajlende c5778d0
Remove incorrect doc param
ajlende 31ac387
Clarify comment
ajlende 17db2d4
Add method version docs
ajlende 25dc819
Fix PHPUnit tests
ajlende 144dc5a
Fix PHPUnit tests
ajlende a592617
Revert to bugged spacing scale check
ajlende 1a3d0c2
Add comment about bad conditional
ajlende 12edffa
Do sorting on all presets in UI only
ajlende 44bf7b8
Add a check that slug begins with a number for sorting
ajlende de077ad
Reorder schema keys
ajlende d9c5c85
Quick fix for redundant info in the defaultFontSizes migration docs
ajlende 1dfcaa3
Update defaultSpacingSizes migration docs to include merging of spaci…
ajlende 2af96a3
Update the global settings and styles guide
ajlende File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Refactor to not need constants
- Loading branch information
commit 9ede3bb61f1291e1ca03529e6dc67c7cb51aef4a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.