Packages: Increase the minimum required Node.js version to v18.12.0#61930
Merged
Packages: Increase the minimum required Node.js version to v18.12.0#61930
Conversation
gziolo
added
npm Packages
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
Node.js v18.12.0 was the first long-term supported version introduced in v18.x line (https://nodejs.org/en/blog/release/v18.12.0). It is now the lowest version that is listed as Maintenance LTS releas at https://nodejs.org/en/about/previous-releases.
gziolo
force-pushed
the
update/minimum-node-version
branch
from
59ec51c to
0bf9830
Compare
gziolo
requested review from
DAreRodz,
ObliviousHarmony,
adamsilverstein,
adamziel,
ajitbohra,
atimmer,
dcalhoun,
dmsnell,
draganescu,
ellatrix,
fluiddot,
kevin940726,
luisherranz,
mmtr,
nerrad,
ntwb,
peterwilsoncc,
ryanwelcher,
swissspidy,
t-hamano and
talldan
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
approved these changes
May 24, 2024
Member
sirreal
left a comment
sirreal
left a comment
There was a problem hiding this comment.
Yes please!
I've reviewed a sample of the changes and they look good.
youknowriad
approved these changes
May 24, 2024
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks for being on top of this.
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…ordPress#61930) * Packages: Increase the minimum required Node.js version to v18.12.0 Node.js v18.12.0 was the first long-term supported version introduced in v18.x line (https://nodejs.org/en/blog/release/v18.12.0). It is now the lowest version that is listed as Maintenance LTS releas at https://nodejs.org/en/about/previous-releases. * Add changelog entries Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…ordPress#61930) * Packages: Increase the minimum required Node.js version to v18.12.0 Node.js v18.12.0 was the first long-term supported version introduced in v18.x line (https://nodejs.org/en/blog/release/v18.12.0). It is now the lowest version that is listed as Maintenance LTS releas at https://nodejs.org/en/about/previous-releases. * Add changelog entries Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Node.js v18.12.0 was the first long-term supported version introduced in v18.x line (https://nodejs.org/en/blog/release/v18.12.0). It is now the lowest version that is listed as Maintenance LTS release at https://nodejs.org/en/about/previous-releases. The same version is bundled with npm 8.19.2. This PR tries to unify the minimum required Node.js version defined in all npm packages published to npm.
Why?
We are approaching another major WordPress release - 6.6.0. It's a good opportunity to ship all the breaking changes batched together with some other changes that landed recently:
While Gutenberg and WordPress core are more strict in defining the minimum required Node.js and npm versions:
I propose we also allow the 18.x line for WordPress packages, which will be actively maintained until the middle of 2025. This will give more time to folks who might still be using Node.js 18 in their projects.
How?
I ensured that all non-private packages have the minimum version defined with the following:
I also updated all corresponding documentation and add changelog entries.
The only exception is
@wordpress/create-block,which aligns more closely with the versions that WordPress and Gutenberg use, as decided separately some time ago.Testing Instructions
There isn't that much to test because
enginesworks mostly as a hint for Node.js, unless the strict check is explicitly enabled in.npmrc. More in https://docs.npmjs.com/cli/v8/using-npm/config#engine-strict.