Skip to content

Post Date block always show the accurate Last Modified Date #61953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimBHowe wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Post Date block always show the accurate Last Modified Date #61953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
491532f
Removed the if statement the would prevent the post modified date fro…
TimBHowe May 24, 2024
1179167
Updated the help text to reflect more accurately what the Display las…
TimBHowe May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/block-library/src/post-date/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,7 @@ export default function PostDateEdit( {
} )
}
checked={ displayType === 'modified' }
help={ __(
'Only shows if the post has been modified'
) }
help={ __( "Show the post's last modified date" ) }
/>
</PanelBody>
</InspectorControls>
Expand Down
13 changes: 4 additions & 9 deletions packages/block-library/src/post-date/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,12 @@ function render_block_core_post_date( $attributes, $content, $block ) {
}

/*
* If the "Display last modified date" setting is enabled,
* only display the modified date if it is later than the publishing date.
* If the "Display last modified date" setting is enabled.
*/
if ( isset( $attributes['displayType'] ) && 'modified' === $attributes['displayType'] ) {
if ( get_the_modified_date( 'Ymdhi', $post_ID ) > get_the_date( 'Ymdhi', $post_ID ) ) {
$formatted_date = get_the_modified_date( empty( $attributes['format'] ) ? '' : $attributes['format'], $post_ID );
$unformatted_date = esc_attr( get_the_modified_date( 'c', $post_ID ) );
$classes[] = 'wp-block-post-date__modified-date';
} else {
return '';
}
$formatted_date = get_the_modified_date( empty( $attributes['format'] ) ? '' : $attributes['format'], $post_ID );
$unformatted_date = esc_attr( get_the_modified_date( 'c', $post_ID ) );
$classes[] = 'wp-block-post-date__modified-date';
}

$wrapper_attributes = get_block_wrapper_attributes( array( 'class' => implode( ' ', $classes ) ) );
Expand Down
Loading