-
Notifications
You must be signed in to change notification settings - Fork 4.8k
ProgressBar: Simplify default width implementation and make it more easily overridable
#61976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
023e5c4
Remove "experimental" designation for `ProgressBar`
fullofcaffeine b1fe7cd
Add optional width prop to override/set the progress bar track container
fullofcaffeine fe9129d
Revert "Add optional width prop to override/set the progress bar trac…
fullofcaffeine 64c72e2
Keep an unconstrained width by default, while allowing consumers to o…
fullofcaffeine c88ece0
Revert "Keep an unconstrained width by default, while allowing consum…
fullofcaffeine ad0fff9
Make the component public
fullofcaffeine dc299ed
Update consumers to import the public component
fullofcaffeine 4c0b8fd
Expose docs for the now public ProgressBar component
fullofcaffeine 0ff6637
Update CHANGELOG
fullofcaffeine ad2fd28
Merge branch 'trunk' into remove/wp-components-experimental-designati…
fullofcaffeine adf39a1
Run docs:build after docs/manifest.js change
fullofcaffeine ceb2840
Merge branch 'trunk' into remove/wp-components-experimental-designati…
fullofcaffeine 9b3db94
Remove remaining private usage of ProgressBar
fullofcaffeine a219fa8
Small formatting fix in the changelog
fullofcaffeine 1d22f24
Add basic docs to the README
fullofcaffeine b096ca4
Add jsdoc
fullofcaffeine 3af0985
Formatting fix in README jsx block
fullofcaffeine 846ccc0
Another formatting fix in README jsx block
fullofcaffeine 39b92a5
YAFF (yet another formatting fix) in the README jsx
fullofcaffeine 3241379
Improve wording in descripton of the `value` prop in the README
fullofcaffeine ff982fb
YAFF: Missing semicolon in README jsx
fullofcaffeine b0eca3f
YAFF: missing semicolon in jsx block in README
fullofcaffeine 59d46cc
YAFF: missing semicolon in jsx block in README
fullofcaffeine 0832e40
YAFF: use tab instead of spaces in jsx code block in README
fullofcaffeine 5ca947a
Move export out of the HOC export section
fullofcaffeine 47183b7
Fix CHANGELOG: Move entry to the existing enhacements section
fullofcaffeine eed1dba
Merge branch 'trunk' into remove/wp-components-experimental-designati…
fullofcaffeine d132170
Spacing fix
fullofcaffeine 43e1a57
Sort import alphabetically
fullofcaffeine 7a00da3
Allow `ProgressBar` to have unconstrained width, which is disabled by…
fullofcaffeine a9c174b
Revert "Allow `ProgressBar` to have unconstrained width, which is dis…
fullofcaffeine 66e8223
Update docs and add story to illustrate a custom width
fullofcaffeine 3a95761
Update CHANGELOG
fullofcaffeine a076910
Merge branch 'trunk' into improve/progress-bar-width-control
fullofcaffeine 2454c7a
Simplify description in the story
fullofcaffeine 981ce6f
Improve jsdoc in story, do not encourage more customization than needed
fullofcaffeine 67d97df
Inherit the second story from the main template
fullofcaffeine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Inherit the second story from the main template
- Loading branch information
commit 67d97df116c87ba655d20a144596e02b4b826c88
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing that's not specific to this PR, but I wonder why we're still using a legacy CSF version, even for new stuff. Haven't checked our current version, but CSF 3 has been supported for the last couple of versions and it makes Storybook much easier to work with. @WordPress/gutenberg-components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should! Nobody hadn't really prioritized it enough.