Skip to content

Tabs: Prevent accidental overflow in indicator #61979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 9 commits into from
Jun 4, 2024
Merged

Tabs: Prevent accidental overflow in indicator #61979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
343911c
Tabs: Consider decimal point in indicator style
t-hamano May 25, 2024
7d82754
Update changelog
t-hamano May 25, 2024
842f53e
Naive solution.
DaniGuardiola Jun 3, 2024
34f47b0
Subpixel size and position workaround.
DaniGuardiola Jun 3, 2024
c9a4938
Merge branch 'trunk' of https://github.com/WordPress/gutenberg into t…
DaniGuardiola Jun 3, 2024
2858be2
Add comment.
DaniGuardiola Jun 3, 2024
7a25f1a
Move CHANGELOG entry to Unreleased section
t-hamano Jun 4, 2024
cfcd05a
Merge branch 'trunk' into tabs/decimal-point-indicator
t-hamano Jun 4, 2024
36ead13
Resolve conflicts
t-hamano Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

- Add `text-wrap: balance` fallback to all instances of `text-wrap: pretty` for greater cross browser compatibility. ([#62233](https://github.com/WordPress/gutenberg/pull/62233))

### Bug Fixes

- `Tabs`: Prevent accidental overflow in indicator ([#61979](https://github.com/WordPress/gutenberg/pull/61979)).

## 28.0.0 (2024-05-31)

### Breaking Changes
Expand Down
10 changes: 6 additions & 4 deletions packages/components/src/tabs/tablist.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,12 @@ function useTrackElementOffset(

function updateIndicator( element: HTMLElement ) {
setIndicatorPosition( {
left: element.offsetLeft,
top: element.offsetTop,
width: element.offsetWidth,
height: element.offsetHeight,
// Workaround to prevent unwanted scrollbars, see:
// https://github.com/WordPress/gutenberg/pull/61979
left: Math.max( element.offsetLeft - 1, 0 ),
top: Math.max( element.offsetTop - 1, 0 ),
width: parseFloat( getComputedStyle( element ).width ),
height: parseFloat( getComputedStyle( element ).height ),
} );
updateCallbackRef.current?.();
}
Expand Down