Remove IS_GUTENBERG_PLUGIN check to ensure pattern overrides ship in 6.6.
#62011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Task
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SantosGuillamot
approved these changes
May 27, 2024
Contributor
SantosGuillamot
left a comment
SantosGuillamot
left a comment
There was a problem hiding this comment.
Looks good to me 🙂
Should we also remove this check in conver-legacy-block.js file? (I am not familiar with that, so I am not sure)
Contributor
Author
This is back compat for something that was only ever shipped in the Gutenberg plugin, so it doesn't need to be shipped to core. Eventually we can remove that code completely from the plugin. |
…on of pattern overrides source
talldan
force-pushed
the
remove/pattern-overrides-feature-flag
branch
from
fb20ec5 to
bf3c2d3
Compare
|
Size Change: 0 B Total Size: 1.74 MB ℹ️ View Unchanged
|
22 tasks
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…on of pattern overrides source (WordPress#62011) Co-authored-by: talldan <[email protected]> Co-authored-by: SantosGuillamot <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…on of pattern overrides source (WordPress#62011) Co-authored-by: talldan <[email protected]> Co-authored-by: SantosGuillamot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverses #59702
What?
In the build up to WordPress 6.5, the pattern overrides feature was bumped from the release.
The
IS_GUTENBERG_PLUGINflag was utilized for this. In both PHP and JS thepattern overridessource would only be registered in the gutenberg plugin.Why?
The plan is to ship it in 6.6.
How?
Removes the use of
IS_GUTENBERG_PLUGIN. While #59702 added the flag in bothlib/load.phpandpackages/editor/src/bindings/index.js, thelib/load.phpflag has already been removed in another change prior to this PR.Only the
jsflag remains, which this PR removes.Testing Instructions
Prerequisites
package.json, change theIS_GUTENBERG_PLUGINproperty tofalse.Test pattern overrides