Skip to content

useUploadMediaFromBlobURL: Prevent duplicate uploads in StrictMode #62059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 2 commits into from
May 28, 2024
Merged

useUploadMediaFromBlobURL: Prevent duplicate uploads in StrictMode #62059

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb81915
useUploadMediaFromBlobURL: Prevent duplicate uploads in StrictMode
Mamaduka May 28, 2024
d75e15b
Add inline comment
Mamaduka May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/block-library/src/utils/hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,20 @@ export function useCanEditEntity( kind, name, recordId ) {
*/
export function useUploadMediaFromBlobURL( args = {} ) {
const latestArgs = useRef( args );
const hasUploadStarted = useRef( false );
const { getSettings } = useSelect( blockEditorStore );

useLayoutEffect( () => {
latestArgs.current = args;
} );

useEffect( () => {
// Uploading is a special effect that can't be canceled via the cleanup method.
// The extra check avoids duplicate uploads in development mode (React.StrictMode).
if ( hasUploadStarted.current ) {
return;
}

if (
! latestArgs.current.url ||
! isBlobURL( latestArgs.current.url )
Expand All @@ -55,6 +62,8 @@ export function useUploadMediaFromBlobURL( args = {} ) {
const { url, allowedTypes, onChange, onError } = latestArgs.current;
const { mediaUpload } = getSettings();

hasUploadStarted.current = true;

mediaUpload( {
filesList: [ file ],
allowedTypes,
Expand All @@ -65,10 +74,12 @@ export function useUploadMediaFromBlobURL( args = {} ) {

revokeBlobURL( url );
onChange( media );
hasUploadStarted.current = false;
},
onError: ( message ) => {
revokeBlobURL( url );
onError( message );
hasUploadStarted.current = false;
},
} );
}, [ getSettings ] );
Expand Down