Skip to content

Add lint rule for inaccessible disabled Button #62080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 26 commits into from
Jun 3, 2024
Merged

Add lint rule for inaccessible disabled Button #62080

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
6ebce5c
Add lint rule for inaccessible disabled `Button`
mirka May 28, 2024
cad8b3e
Exclude react native files
mirka May 28, 2024
9154483
Include files in root `storybook` folder
mirka May 30, 2024
7040967
Fix in Storybook editor playground (matches actual behavior)
mirka May 30, 2024
7a705eb
Fix in install block button (is clearly a busy state)
mirka May 30, 2024
cfefecc
Ignore in gallery image reordering buttons
mirka May 30, 2024
bb06929
Fix in LinkControl copy link button (aleviates confusion)
mirka May 30, 2024
a5696ec
Ignore in edit-site pagination buttons (not confusing, and useful)
mirka May 30, 2024
07b64d3
Fix in enable custom fields (is clearly a busy state)
mirka May 30, 2024
d94c5fb
Fix in DataViews list view
mirka May 30, 2024
0ec3bd9
Fix in DataViews CompactItemActions (is dropdown trigger)
mirka May 30, 2024
16ddf06
Fix in template part title modal
mirka May 30, 2024
8e72fa3
Fix in PageList block (should be perceivable, esp. because the descri…
mirka May 30, 2024
fc29ec1
Fix in ConvertToLinksModal button (should be perceivable, and doesn't…
mirka May 30, 2024
c666444
Fix in edit-site "Apply globally" button (should be perceivable, and …
mirka May 30, 2024
7e05a82
Fix in edit-site nav menu rename modal (should be perceivable to sign…
mirka May 30, 2024
a111992
Fix in RevisionsButtons (button is never visible when `areStylesEqual`)
mirka May 30, 2024
b6b9f09
Fix in RevisionsButtons (contains important info and should be percei…
mirka May 30, 2024
388112f
Fix in GlobalStylesSidebar (should be perceivable)
mirka May 30, 2024
f4d5ae2
Fix in PostPublishPanel cancel button (can cause focus loss)
mirka May 30, 2024
def18f4
Fix in PostPreviewButton (should be perceivable)
mirka May 30, 2024
8ff5fe9
Defer decision in ButtonBlockAppender
mirka May 30, 2024
d188fc5
Fix in reusable blocks import form (should be perceivable, can cause …
mirka May 30, 2024
6f39b75
Adapt test for PostPreviewButton
mirka May 30, 2024
bca37a2
Improve rigidity of accessible disabled detection in test
mirka Jun 3, 2024
d16d2b4
Add disable reason for ButtonBlockAppender
mirka Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix in ConvertToLinksModal button (should be perceivable, and doesn't… 
… clutter tab order)
  • Loading branch information
@mirka
mirka committed May 30, 2024
commit fc29ec106d80efbb462b2bd117f1c62934a08ea1
1 change: 1 addition & 0 deletions packages/block-library/src/page-list/convert-to-links-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export function ConvertToLinksModal( { onClick, onClose, disabled } ) {
</Button>
<Button
variant="primary"
__experimentalIsFocusable
Copy link
Member Author

@mirka mirka May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be perceivable, and doesn't clutter tab sequence.

disabled={ disabled }
onClick={ onClick }
>
Expand Down