Tests: Change how directives processing gets disabled #62095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neccessary for the planned changes in WordPress core: WordPress/wordpress-develop#6331.
gziolo
requested review from
cbravobernal
and removed request for
ajitbohra,
nerrad and
ntwb
gziolo
added
[Package] Interactivity
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ packages/e2e-tests/plugins/interactive-blocks.php |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
May 29, 2024
Integrates the directives processing into the WP_Block class. It removes the overhead of running additional hooks when rendering blocks and simplifies the way we detect whether the directive processing should run on an interactive region of the produced final HTML for the blocks. Introduces `interactivity_process_directives` filter to offer a way to opt out from directives processing. It's needed in Gutenberg: WordPress/gutenberg#62095. Props gziolo, cbravobernal. Fixes #61185. git-svn-id: https://develop.svn.wordpress.org/trunk@58234 602fd350-edb4-49c9-b593-d223f7449a82
Member
Author
|
WP core changes landed so we need it now: WordPress/wordpress-develop@4b91a59. |
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
May 29, 2024
Integrates the directives processing into the WP_Block class. It removes the overhead of running additional hooks when rendering blocks and simplifies the way we detect whether the directive processing should run on an interactive region of the produced final HTML for the blocks. Introduces `interactivity_process_directives` filter to offer a way to opt out from directives processing. It's needed in Gutenberg: WordPress/gutenberg#62095. Props gziolo, cbravobernal. Fixes #61185. Built from https://develop.svn.wordpress.org/trunk@58234 git-svn-id: http://core.svn.wordpress.org/trunk@57697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
May 29, 2024
Integrates the directives processing into the WP_Block class. It removes the overhead of running additional hooks when rendering blocks and simplifies the way we detect whether the directive processing should run on an interactive region of the produced final HTML for the blocks. Introduces `interactivity_process_directives` filter to offer a way to opt out from directives processing. It's needed in Gutenberg: WordPress/gutenberg#62095. Props gziolo, cbravobernal. Fixes #61185. Built from https://develop.svn.wordpress.org/trunk@58234 git-svn-id: https://core.svn.wordpress.org/trunk@57697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Neccessary for the planned changes in WordPress core: WordPress/wordpress-develop#6331. Co-authored-by: gziolo <[email protected]> Co-authored-by: cbravobernal <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Neccessary for the planned changes in WordPress core: WordPress/wordpress-develop#6331. Co-authored-by: gziolo <[email protected]> Co-authored-by: cbravobernal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The necessary steps for the planned changes in WordPress core are as follows: WordPress/wordpress-develop#6331.
Why?
The existing filter gets replaced with more thigh integration with the
WP_Blockclass.How?
New filter
interactivity_process_directivesgets introduced to allow controlling directives processing for Interactivity API.Testing Instructions
E2E tests should still pass after changes land in WordPress core. It will fail currently.