Skip to content

MediaUpload: Keep track of the dialog state #62108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mamaduka wants to merge 1 commit into from
Closed

MediaUpload: Keep track of the dialog state #62108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/media-utils/src/components/media-upload/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,10 +396,11 @@ class MediaUpload extends Component {

onClose() {
const { onClose } = this.props;

if ( onClose ) {
onClose();
}

this.isModalOpen = false;
Copy link
Member Author

@Mamaduka Mamaduka May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no Media Library code expert, but I think we should call this.frame.detach() on close action. Otherwise, the modal leaves some "breadcrumbs" in the DOM. Core does a similar thing for classic widgets.

Screenshot

CleanShot 2024-05-29 at 19 37 13

Copy link
Member

@joemcgill joemcgill May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a longer reply in Slack. TL;DR I agree.

}

updateCollection() {
Expand All @@ -421,6 +422,10 @@ class MediaUpload extends Component {
}

openModal() {
if ( this.isModalOpen ) {
return;
}

const {
allowedTypes,
gallery = false,
Expand Down Expand Up @@ -454,6 +459,7 @@ class MediaUpload extends Component {
}
this.initializeListeners();
this.frame.open();
this.isModalOpen = true;
}

render() {
Expand Down