Skip to content

Force POSIX implementation for strings relative path output #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 2 commits into from
May 4, 2017
Merged

Force POSIX implementation for strings relative path output #622

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6f63af
Force POSIX implementation for strings relative path output
aduth May 3, 2017
4a76421
Replace path separators in i18n file reference
aduth May 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Replace path separators in i18n file reference
  • Loading branch information
@aduth
aduth committed May 4, 2017
commit 4a76421dff4b536bca00ccfa4e10e27ca64461b1
8 changes: 5 additions & 3 deletions i18n/babel-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

const { po } = require( 'gettext-parser' );
const { pick, reduce, uniq, forEach, sortBy, isEqual, merge, isEmpty } = require( 'lodash' );
const { relative } = require( 'path' ).posix;
const { relative, sep } = require( 'path' );
const { writeFileSync } = require( 'fs' );

/**
Expand Down Expand Up @@ -199,10 +199,12 @@ module.exports = function() {
translation.msgstr = '';
}

// Assign file reference comment
// Assign file reference comment, ensuring consistent pathname
// reference between Win32 and POSIX
const { filename } = this.file.opts;
const pathname = relative( '.', filename ).split( sep ).join( '/' );
translation.comments = {
reference: relative( process.cwd(), filename ) + ':' + path.node.loc.start.line
reference: pathname + ':' + path.node.loc.start.line
};

// If exists, also assign translator comment
Expand Down