Skip to content

Top toolbar: fix half a pixel artifacting of the bottom border. #62225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
draganescu merged 7 commits into from
Jun 4, 2024
Merged

Top toolbar: fix half a pixel artifacting of the bottom border. #62225

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2ad2018
Top toolbar: fix half a pixel artifacting of the bottom border.
jasmussen Jun 3, 2024
0ab0f84
Address feedback.
jasmussen Jun 3, 2024
617c217
Restore previous fix after all.
jasmussen Jun 3, 2024
5cb9c5c
Use transparent background color.
jasmussen Jun 4, 2024
8f9526d
Update changelog.
jasmussen Jun 4, 2024
fb1e226
Move the rule to the right place.
jasmussen Jun 4, 2024
26bb3be
Remove entry from changelog.
jasmussen Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Top toolbar: fix half a pixel artifacting of the bottom border.
  • Loading branch information
@jasmussen
jasmussen committed Jun 4, 2024
commit 2ad2018ccb1216f6ae7e931870a001161521479f
2 changes: 2 additions & 0 deletions packages/editor/src/components/header/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
// Leave enough room for the focus ring to show.
padding: 2px 0;
align-items: center;
// Fix visual artifacting at the bottom.
max-height: $header-height - $border-width;
// Allow focus ring to be fully visible on furthest right button.
@include break-medium() {
padding-right: var(--wp-admin-border-width-focus);
Expand Down