Skip to content

Replace exec with spawn in performance runner script #62270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WunderBart wants to merge 9 commits into from
Closed

Replace exec with spawn in performance runner script #62270

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d39e0c0
Promisify exec recommended way
WunderBart Jun 4, 2024
4dd2039
tmp: fail the test on purpose to see the logs
WunderBart Jun 4, 2024
4fe966f
try using spawn
WunderBart Jun 4, 2024
720fc5b
try using the runner script directly
WunderBart Jun 4, 2024
01694fa
Better errors
jsnajdr Jun 5, 2024
27d4a6a
remove obsolete typedef
WunderBart Jun 5, 2024
2c7e3f3
enable list reporter in CI
WunderBart Jun 5, 2024
9aec5fe
tmp: add more logs for inspection
WunderBart Jun 5, 2024
d328e03
add retry mechanism to the REST API discovery
WunderBart Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove obsolete typedef
  • Loading branch information
@WunderBart
WunderBart committed Jun 5, 2024
commit 27d4a6a1e46c9a8b3917050f2b7817bb0ed9d659
2 changes: 0 additions & 2 deletions bin/plugin/lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ const { log, formats } = require( './logger' );
/**
* Utility to run a child script
*
* @typedef {NodeJS.ProcessEnv} Env
*
* @param {string} command
* @param {string[]} args
* @param {import('child_process').SpawnOptions} options
Expand Down