-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Update dummy content to function as an introduction to the editor. #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I really quite like this. It's very inspiring to see it come together cohesively like this. Really makes me excited to polish the embed block, the image blocks, the rest of the post content... the whole thing. Very very cool. There's one blocker, though. As a dane I consider it my solemn duty to defend the fact that LEGO is in allcaps. Always. Edit: Also, LEGO is the plural of LEGO. Examples:
This is important stuff. |
post-content.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the individual words marked bold, instead of one tag encompassing both words?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, just an artifact, will fix.
|
Can you use a longer blockquote, with some |
d544a39 to
ca26626
Compare
|
Added some images and text at the bottom. Should we find a different video, or move it upwards, out of the "lorem ipsum" text at the bottom? |
|
I moved the video and added a caption. I think we should merge this in and keep moving. |
Also snuck in a "code" so we can check the link boundary.
e41c43e to
f04d10b
Compare
|
Merged, we'll keep refining this. |
|
The embed block's comment syntax should have been updated with consideration for #626. |
|
I missed it was broken after the rebase. |
|
Pretty sure that was my fault. Apologies, fixing. |
|
@jasmussen already submitted #675 |
This fixes a regression I introduced in #623 (comment).
|
Hah, sorry, deleting mine. |
No description provided.