Skip to content

Global styles revisions: ensure that user-defined variation styles CSS is generated #62768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonjd merged 10 commits into from
Jun 27, 2024
Merged

Global styles revisions: ensure that user-defined variation styles CSS is generated #62768

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
69b219e
Render styles after the variation style overrides have been saved to …
ramonjd Jun 24, 2024
1b4e3c5
For every current override, update the variation CSS with the incomin…
ramonjd Jun 24, 2024
5189486
Rename hook
ramonjd Jun 24, 2024
3d583c8
Fetching overrides in the hook
ramonjd Jun 24, 2024
2853fb3
Feedback suggestions from review:
ramonjd Jun 25, 2024
375470e
Return getBlockStyles from the useSelect callback
ramonjd Jun 25, 2024
b9eb758
Refactor so we don't have to change the EditorStyles props
ramonjd Jun 26, 2024
fcebc07
Adding some explanatory comments
ramonjd Jun 26, 2024
2e3c9d8
Removed unused style fixture
ramonjd Jun 26, 2024
55cc60c
Removed unused style fixture
ramonjd Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Render styles after the variation style overrides have been saved to … 
…stage.

Getting closer. But the overrides in state need to be merged with incoming revision styles.
  • Loading branch information
@ramonjd
ramonjd committed Jun 27, 2024
commit 69b219e300aeae3ad4035ad527cc7654ace90a82
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/revisions/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ function Revisions( { userConfig, blocks } ) {
name="revisions"
tabIndex={ 0 }
>
<EditorStyles styles={ editorStyles } />
<style>
{
// Forming a "block formatting context" to prevent margin collapsing.
Expand All @@ -88,6 +87,7 @@ function Revisions( { userConfig, blocks } ) {
settings={ settings }
>
<BlockList renderAppender={ false } />
<EditorStyles styles={ editorStyles } />
</ExperimentalBlockEditorProvider>
</Disabled>
</Iframe>
Expand Down