Skip to content

Only apply output buffer filter when in final phase #62770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
westonruter wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Only apply output buffer filter when in final phase #62770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions lib/experimental/full-page-client-side-navigation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,17 @@ function _gutenberg_add_client_side_navigation_directives( $response_body ) {
*/
function _gutenberg_buffer_template_output( string $passthrough ): string {
ob_start(
static function ( string $output ): string {
/**
* Filters the template output buffer prior to sending to the client.
*
* @param string $output Output buffer.
* @return string Filtered output buffer.
*/
return (string) apply_filters( 'gutenberg_template_output_buffer', $output );
static function ( string $output, ?int $phase ): string {
if ( $phase & PHP_OUTPUT_HANDLER_FINAL ) {
/**
* Filters the template output buffer prior to sending to the client.
*
* @param string $output Output buffer.
* @return string Filtered output buffer.
*/
$output = (string) apply_filters( 'gutenberg_template_output_buffer', $output );
}
return $output;
}
);
return $passthrough;
Expand Down