-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Block bindings: UI for connecting bindings #62880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
ae6afbc
Initial experiment
cbravobernal 5efa047
First experiment of raw custom field for P
cbravobernal 0a1b636
use selectors
cbravobernal 1f9900e
Use lists
cbravobernal 8128c0f
Remove
cbravobernal 4eac7dc
Fix removing
cbravobernal db906bd
Add new ui
cbravobernal e357882
Update attributes
cbravobernal 1a18fb6
Check binded number
cbravobernal 39b2efa
Check binded number
cbravobernal 8484002
Move bindings panel to editor
cbravobernal 88759d3
Move code
cbravobernal aa626fe
Move to utils
cbravobernal be20d24
Use tools panel for connections
cbravobernal 5343678
Add reset
cbravobernal 58054eb
Add bordered items
cbravobernal 8e8a122
Fix some styles
cbravobernal 683abfb
Move utils back to component
cbravobernal d3ba547
Remove not needed comments
cbravobernal 3b703f7
Some refactor
cbravobernal f0cd95a
Prevent UI with no meta data
cbravobernal 3bc6072
Add helper
cbravobernal da6845e
Add helper
cbravobernal 28ceffe
Add simple e2e
cbravobernal a90d9da
Add one more menuitem to the list
cbravobernal 2df3ef3
Update e2e tests now a new tab appears by default
cbravobernal 6be1849
Another test
cbravobernal 0380ee8
Add e2e to check paragraph
cbravobernal fe88757
Remove not needed experiment
cbravobernal 41691df
Remove extra blank spaces
cbravobernal 4f097d0
update e2e
cbravobernal 6e04036
Keep updating e2e
cbravobernal 51904df
Remove css to the minimum
cbravobernal 28ba254
Less CSS
cbravobernal 25051fc
Abstract fields and move hooks back to block-editor
SantosGuillamot 981367a
Return null when no bindableAttributes
SantosGuillamot b1aaa7a
Add checks to registration
SantosGuillamot 3d9182e
Fix when the list of fields is empty
SantosGuillamot ff7c393
Properly filter footnotes
SantosGuillamot f2469c9
Update tests
cbravobernal 26b5988
Remove classes from component
cbravobernal 8798953
Remove all components mention
cbravobernal 27639ba
Add ignore console error
cbravobernal f0a0680
Add icons and fix styling
cbravobernal 42693a4
Remove not needed as p
cbravobernal b7efec2
Remove icon
cbravobernal 11b2a4b
Remove icons, show label only if there are more than one source
cbravobernal 58eb28c
Simplify style names
cbravobernal d17b593
Adapt design
cbravobernal dfeba8b
Use `ItemGroup` inside `ToolsPanel`
SantosGuillamot 9e67785
Use `Text` component
SantosGuillamot b19d01e
Use `getBlockBindingsSources` function
SantosGuillamot fb4a51b
Revert change to popover max-width
SantosGuillamot 6439308
Remove not used classes
SantosGuillamot 9f277b3
Remove unused props
SantosGuillamot 0beff34
Add fallbacks for undefined keys
SantosGuillamot 8e6ad14
Try: Use `DropdownMenuV2`
SantosGuillamot c9ea7c7
Add button to remove the binding
SantosGuillamot 436c97f
Reduce truncate lines to 1
SantosGuillamot 9896dbf
Fix labels when multiple sources
SantosGuillamot 752d7e0
Try: Add readOnly support when fields are undefined
SantosGuillamot feb890d
Use RadioItem instead of Checkbox
SantosGuillamot 8bb9136
Remove "Clear" button
SantosGuillamot 22e1020
Remove clear button CSS
SantosGuillamot cabd3d8
Don't use DropdownItems outside Dropdown
SantosGuillamot b814725
Move separator inside menu group
SantosGuillamot 591bd72
Use onChange to better align with radio behavior
artemiomorales 8ffc7f4
Add aria-hiddden to group heading
artemiomorales 13cd09e
Update tests
artemiomorales 3a086ab
Reduce custom styles
SantosGuillamot 12c9088
Properly add block context after latest changes
SantosGuillamot bc05788
Adapt tests
SantosGuillamot a9b347f
Remove `numberOfLines` prop
SantosGuillamot 839b37a
Remove unused class
SantosGuillamot 01fcf7d
Fix mobile popover
SantosGuillamot d14d50f
Move Separator outside of `DropdownMenuGroup`
SantosGuillamot 2dff252
Remove empty sources from `fieldsList`
SantosGuillamot 50f6f1e
Move UI under experimental flag
SantosGuillamot 3bf117c
Adapt e2e changes to experimental flag
SantosGuillamot 6fb7d89
Remove missing clicks in tests
SantosGuillamot d091c34
Adapt another test
SantosGuillamot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add helper
- Loading branch information
commit da6845ec254e79b37b386343e1b5629bb14a502a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.