Skip to content

CustomSelectControl V2: keep legacy arrow down behavior only for legacy wrapper #62919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 7 commits into from
Jul 4, 2024
Merged

CustomSelectControl V2: keep legacy arrow down behavior only for legacy wrapper #62919

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1d49232
Use isLelacy flag to enable/disable showOnKeyDown behavior
ciampo Jun 27, 2024
97daf96
Add unit tests
ciampo Jun 27, 2024
8d8c37e
CHANGELOG
ciampo Jun 27, 2024
722dc8a
Unit tests: Add `sleep()` before pressing `Tab` key
ciampo Jul 1, 2024
9c0b212
Use label when checking that the listbox hasn't opened
ciampo Jul 1, 2024
9286559
Use label variable instead of hardcoded string
ciampo Jul 1, 2024
1b388cc
Use `Ariakit.Select` prop types instead of `CustomSelectButtonInterna…
ciampo Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Unit tests: Add sleep() before pressing Tab key
  • Loading branch information
@ciampo
ciampo committed Jul 2, 2024
commit 722dc8a1d97fe2c959a52892712a44b41077d782
1 change: 1 addition & 0 deletions packages/components/src/custom-select-control-v2/legacy-component/test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,7 @@ describe.each( [
expanded: false,
} );

await sleep();
await press.Tab();
Comment thread
ciampo marked this conversation as resolved.
expect( currentSelectedItem ).toHaveFocus();
expect( currentSelectedItem ).toHaveTextContent(
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/custom-select-control-v2/test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,7 @@ describe.each( [
expanded: false,
} );

await sleep();
await press.Tab();
Comment thread
ciampo marked this conversation as resolved.
expect( currentSelectedItem ).toHaveFocus();
expect( currentSelectedItem ).toHaveTextContent( items[ 0 ].value );
Expand Down