Skip to content

Add aria-pressed to the editor toolbar toggle buttons. #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasmussen merged 2 commits into from
May 8, 2017
Merged

Add aria-pressed to the editor toolbar toggle buttons. #630

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f9ef25
Add aria-pressed to the editor toolbar toggle buttons.
afercia May 3, 2017
9cf620e
Avoid unnecessary ternary.
afercia May 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add aria-pressed to the editor toolbar toggle buttons.
  • Loading branch information
@afercia
afercia committed May 3, 2017
commit 4f9ef25629f3a77c7913dafc6a127125ba2352a9
4 changes: 3 additions & 1 deletion editor/components/toolbar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ function Toolbar( { controls } ) {
} }
className={ classNames( 'editor-toolbar__control', {
'is-active': control.isActive
} ) } />
} ) }
aria-pressed={ control.isActive ? 'true' : 'false' }
Copy link
Member

@nylen nylen May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should just be { control.isActive }.

/>
) ) }
</ul>
);
Expand Down