Skip to content

Block Bindings: Improve the way block bindings sources are registered #63117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SantosGuillamot merged 15 commits into from
Jul 16, 2024
Merged

Block Bindings: Improve the way block bindings sources are registered #63117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d716b5f
Move bindings registration to editor provider
SantosGuillamot Jul 4, 2024
6f2ab12
Remove old bindings import
SantosGuillamot Jul 4, 2024
6cabef4
Remove sources from editor provider
SantosGuillamot Jul 4, 2024
4701034
Create registerBlockBindingsSource
SantosGuillamot Jul 4, 2024
db6f4d4
Export function as private
SantosGuillamot Jul 4, 2024
d776739
Create `registerCoreBlockBindingsSources` function
SantosGuillamot Jul 4, 2024
d6978d8
Register core sources in edit-post and edit-site
SantosGuillamot Jul 4, 2024
efc1450
Don't reuse existing source
SantosGuillamot Jul 4, 2024
2a314b1
Add comment explaining function
SantosGuillamot Jul 4, 2024
e8e248c
Change the object in registration
SantosGuillamot Jul 11, 2024
2c99727
Add a few checks more
SantosGuillamot Jul 12, 2024
715911d
Add more registration functions
SantosGuillamot Jul 12, 2024
2866f51
Add private action to remove binding source
SantosGuillamot Jul 12, 2024
422aef7
Add unit tests
SantosGuillamot Jul 12, 2024
c27eed8
Export all functions as private
SantosGuillamot Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Register core sources in edit-post and edit-site
  • Loading branch information
@SantosGuillamot
SantosGuillamot committed Jul 4, 2024
commit d6978d8ca4c61431c67761844ff3b7bd2e2bced7
2 changes: 2 additions & 0 deletions packages/edit-post/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import { unlock } from './lock-unlock';
const {
BackButton: __experimentalMainDashboardButton,
registerDefaultActions,
registerCoreBlockBindingsSources,
} = unlock( editorPrivateApis );

/**
Expand Down Expand Up @@ -86,6 +87,7 @@ export function initializeEditor(
}

registerCoreBlocks();
registerCoreBlockBindingsSources();
registerLegacyWidgetBlock( { inserter: false } );
registerWidgetGroupBlock( { inserter: false } );
if ( globalThis.IS_GUTENBERG_PLUGIN ) {
Expand Down
4 changes: 3 additions & 1 deletion packages/edit-site/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ import { store as editSiteStore } from './store';
import { unlock } from './lock-unlock';
import App from './components/app';

const { registerDefaultActions } = unlock( editorPrivateApis );
const { registerDefaultActions, registerCoreBlockBindingsSources } =
unlock( editorPrivateApis );

/**
* Initializes the site editor screen.
Expand All @@ -45,6 +46,7 @@ export function initializeEditor( id, settings ) {
( { name } ) => name !== 'core/freeform'
);
registerCoreBlocks( coreBlocks );
registerCoreBlockBindingsSources();
dispatch( blocksStore ).setFreeformFallbackBlockName( 'core/html' );
registerLegacyWidgetBlock( { inserter: false } );
registerWidgetGroupBlock( { inserter: false } );
Expand Down