Skip to content

Pattern overrides: Ensure "Reset" button always shows as last item and with border #63291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SantosGuillamot merged 1 commit into from
Jul 13, 2024
Merged

Pattern overrides: Ensure "Reset" button always shows as last item and with border #63291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/patterns/src/components/reset-overrides-control.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*/
import {
store as blockEditorStore,
BlockControls,
__unstableBlockToolbarLastItem as BlockToolbarLastItem,
Copy link
Member

@ellatrix ellatrix Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're not currently using that for anything. 🤔

Copy link
Member

@ellatrix ellatrix Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was introduced in #39290.

Copy link
Member

@ellatrix ellatrix Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @youknowriad has an opinion here (I think you added the grouping once upon a time). But I'm not against this approach.

Copy link
Contributor Author

@SantosGuillamot SantosGuillamot Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right it is not used anymore 🤷 It seems it was also used in this pull request, and the initial implementation was "removed" in this other one.

} from '@wordpress/block-editor';
import { ToolbarButton, ToolbarGroup } from '@wordpress/components';
import { useRegistry, useSelect } from '@wordpress/data';
Expand Down Expand Up @@ -79,12 +79,12 @@ export default function ResetOverridesControl( props ) {
}

return (
<BlockControls group="other">
<BlockToolbarLastItem>
<ToolbarGroup>
<ToolbarButton onClick={ onClick } disabled={ ! isOverriden }>
{ __( 'Reset' ) }
</ToolbarButton>
</ToolbarGroup>
</BlockControls>
</BlockToolbarLastItem>
);
}