Skip to content

Navigation block: Allow themes to override block library text-decoration rule #63406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
talldan merged 3 commits into from
Jul 17, 2024
Merged

Navigation block: Allow themes to override block library text-decoration rule #63406

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be5ae55
Reduce specificity of navigation text decoration rule
talldan Jul 11, 2024
0f9669a
Apply Aaron suggestion to also lower specificity for focus/active
talldan Jul 12, 2024
56fcc6f
Remove `:not([class*="has-text-decoration"])` from selector
talldan Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove :not([class*="has-text-decoration"]) from selector
  • Loading branch information
@talldan
talldan committed Jul 16, 2024
commit 56fcc6f97045c28e31778bd1f77b8a49e1e3f58e
10 changes: 4 additions & 6 deletions packages/block-library/src/navigation/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,10 @@ $navigation-icon-size: 24px;
}
}

&:where(:not([class*="has-text-decoration"])) {
& :where(a),
& :where(a:focus),
& :where(a:active) {
text-decoration: none;
}
& :where(a),
& :where(a:focus),
& :where(a:active) {
text-decoration: none;
}

// Submenu indicator.
Expand Down