Skip to content

Font Library: Improve 'No fonts installed' state when fonts are installed but not activated #63533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akasunil merged 8 commits into from
Jul 22, 2024
Merged

Font Library: Improve 'No fonts installed' state when fonts are installed but not activated #63533

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
610e6ea
Change message when fonts are installed but not activated
akasunil Jul 14, 2024
27fffd3
Add custom installed fonts condition for message
akasunil Jul 16, 2024
04e2e40
Add installed fonts condition over button text and button action
akasunil Jul 16, 2024
583065c
Merge branch 'trunk' of personal.github.com:WordPress/gutenberg into …
akasunil Jul 17, 2024
f717121
Merge branch 'trunk' of personal.github.com:WordPress/gutenberg into …
akasunil Jul 18, 2024
302371f
Fix e2e test
akasunil Jul 18, 2024
d3ca774
Merge branch 'trunk' of personal.github.com:WordPress/gutenberg into …
akasunil Jul 18, 2024
691edc7
Synced with trunk
akasunil Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/edit-site/src/components/global-styles/font-families.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ const { useGlobalSetting } = unlock( blockEditorPrivateApis );
function FontFamilies() {
const { modalTabOpen, setModalTabOpen } = useContext( FontLibraryContext );
const [ fontFamilies ] = useGlobalSetting( 'typography.fontFamilies' );
const [ baseFontFamilies ] = useGlobalSetting(
'typography.fontFamilies',
undefined,
'base'
);
const themeFonts = fontFamilies?.theme
? fontFamilies.theme
.map( ( f ) => setUIValuesNeeded( f, { source: 'theme' } ) )
Expand All @@ -39,6 +44,7 @@ function FontFamilies() {
.sort( ( a, b ) => a.name.localeCompare( b.name ) )
: [];
const hasFonts = 0 < customFonts.length || 0 < themeFonts.length;
const hasBaseFonts = baseFontFamilies?.theme?.length > 0;
Copy link
Contributor

@matiasbenedetto matiasbenedetto Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conditional is not enough to know if there are fonts installed but not activated. Currenty, this only checks if the theme provides fonts that are not activated but it doesn't check if there are custom fonts installed but they are not activated.

Copy link
Member Author

@akasunil akasunil Jul 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right; it's likely possible that the only available fonts are custom ones that haven't been activated. I'll update the PR


return (
<>
Expand Down Expand Up @@ -81,7 +87,11 @@ function FontFamilies() {
{ ! hasFonts && (
<VStack>
<Subtitle level={ 3 }>{ __( 'Fonts' ) }</Subtitle>
<Text as="p">{ __( 'No fonts installed.' ) }</Text>
<Text as="p">
{ hasBaseFonts
? __( 'No fonts activated.' )
: __( 'No fonts installed.' ) }
</Text>
</VStack>
) }
<Button
Expand Down