Skip to content

Update template description in table layout #63942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameskoster merged 7 commits into from
Jul 29, 2024
Merged

Update template description in table layout #63942

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fd10ed6
Update template description in table layout
jameskoster Jul 25, 2024
57587d6
Remove variable
jameskoster Jul 26, 2024
ef0c64e
Add text-wrap fallback for Safari
jameskoster Jul 26, 2024
aaff558
Rebase
jameskoster Jul 26, 2024
18af502
Adjust margin styling
jameskoster Jul 26, 2024
11cc9cb
Remove unnecessary display property
jameskoster Jul 26, 2024
c61172d
Refactor
jameskoster Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust margin styling
  • Loading branch information
@jameskoster
jameskoster committed Jul 26, 2024
commit 18af5024ed3dc21a2dd500ab98e4ff27626ac45a
10 changes: 6 additions & 4 deletions packages/edit-site/src/components/page-templates/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,17 @@
}
}

.dataviews-view-table {
.page-templates-description {
margin-bottom: $grid-unit-10;
Copy link
Contributor

@t-hamano t-hamano Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be simpler to move this style here. I think the selector .page-templates-description is enough.

Copy link
Contributor Author

@jameskoster jameskoster Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this then the margin will also be applied in Grid and List layouts, which we do not want.

Copy link
Contributor

@t-hamano t-hamano Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's true. How about the following? It may be a matter of preference.

.page-templates-description {
	max-width: 50em;
	text-wrap: balance; // Fallback for Safari
	text-wrap: pretty;

	.dataviews-view-table & {
		margin-bottom: $grid-unit-10;
	}
}

Copy link
Contributor Author

@jameskoster jameskoster Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sure, I always forget about that selector.

}
}

.page-templates-description {
display: block;
max-width: 50em;
text-wrap: balance; // Fallback for Safari
text-wrap: pretty;

&.is-viewtype-table {
margin-bottom: $grid-unit-10;
}
}

.edit-site-page-templates {
Expand Down