Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
fe0aaee
Add initial accordion implementation.
jffng Jul 30, 2024
ebfc5f5
Refactor blocks for core loading.
jffng Jul 30, 2024
c58232f
Simplify state getter by storing id in the context.
jffng Aug 1, 2024
4698eee
Clean up tag processing and try to initialize state on the server.
jffng Aug 2, 2024
3c2c54b
Don't enqueue the frontend files if there's no content
luisherranz Aug 6, 2024
d4101b4
Stringify the autoclose value
luisherranz Aug 6, 2024
872ecf1
Refactor to populate `context.isOpen` on the server
luisherranz Aug 6, 2024
5f9e24a
Add comments to the server side rendering functions.
jffng Aug 6, 2024
b790e90
Improve the block editing UX
jffng Aug 6, 2024
7a05993
Reword the auto-close toggle help text.
jffng Aug 12, 2024
cea68d0
Add padding to the content and trigger by default.
jffng Aug 12, 2024
96c37c9
Fix aria-labelledby and aria-controls references.
jffng Aug 14, 2024
151655b
Allow HeadingLevelOptions to be extended.
jffng Aug 14, 2024
37315e4
Only allow bold, italic, image, and strikethrough for the Trigger.
jffng Aug 16, 2024
7f17891
Disable keyboard navigation for focusable elements when aria-hidden i…
jffng Aug 16, 2024
6c91e72
Fix __next40pxDefaultSize linting error.
jffng Aug 16, 2024
72fdd46
Refactor how state and context are initialized to avoid the need for …
jffng Aug 16, 2024
5967cf1
Use strings for openByDefault so boolean is in the generated JSON.
jffng Sep 3, 2024
db03ba8
Use inert instead of aria-hidden.
jffng Sep 3, 2024
93deeee
Rename Trigger and Content to Header and Panel.
jffng Sep 16, 2024
84112e3
Rename interactivity to script modules.
jffng Sep 16, 2024
542ac20
Remove unused watch directive for setting the tabIndex.
jffng Sep 16, 2024
2d07fba
Merge branch 'trunk' into try/accordion-block
mikachan Aug 4, 2025
5ccd5e3
Move icon controls to top level
mikachan Aug 5, 2025
89f3ffd
Fix linting
mikachan Aug 5, 2025
2916ba6
Remove old GB experiments
mikachan Aug 5, 2025
6fa545e
Remove icon selection
mikachan Aug 8, 2025
df7ee79
Select first Accordion Header by default
mikachan Aug 8, 2025
1715381
Fix icon logic in save.js
mikachan Aug 8, 2025
8d3aa4a
Remove layout controls from header and panel
mikachan Aug 8, 2025
0f2ee27
Fix RTL icon position
mikachan Aug 8, 2025
445f1d1
Remove layout from group and item
mikachan Aug 8, 2025
d4bb0e4
Add layout to accordion group
mikachan Aug 11, 2025
f713c57
Rename Accordion Group to Accordions
mikachan Aug 12, 2025
fb546f7
Use single useSelect
mikachan Aug 13, 2025
0be4b65
Move accordion icons to icon library
mikachan Aug 13, 2025
237af26
Remove color and padding from heading styles
mikachan Aug 13, 2025
43dc276
Make heading CSS less specific
mikachan Aug 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add padding to the content and trigger by default.
  • Loading branch information
jffng committed Sep 16, 2024
commit cea68d0ba3a2bae14879ed930b9c27dddd9c9e2d
157 changes: 79 additions & 78 deletions packages/block-library/src/accordion-group/style.scss
Original file line number Diff line number Diff line change
@@ -1,93 +1,94 @@
.wp-block-accordion-group {
.wp-block-accordion-item {
display: grid;
grid-template-rows: max-content 0fr;
}
.wp-block-accordion-item {
display: grid;
grid-template-rows: max-content 0fr;
}

.wp-block-accordion-item.is-open {
grid-template-rows: max-content 1fr;
}
.wp-block-accordion-item.is-open {
grid-template-rows: max-content 1fr;
}

.wp-block-accordion-item .accordion-item__heading {
color: inherit;
padding: 0;
margin: 0;
}
.wp-block-accordion-item .accordion-item__heading {
color: inherit;
padding: 0;
margin: 0;
}

.accordion-item__toggle {
font-family: inherit;
font-size: inherit;
font-weight: inherit;
line-height: inherit;
letter-spacing: inherit;
text-transform: inherit;
text-decoration: inherit;
word-spacing: inherit;
background: none;
border: none;
color: inherit;
padding: 0;
cursor: pointer;
outline: none;
display: flex;
align-items: center;
text-align: inherit;
position: relative;
width: 100%;
}
.accordion-item__toggle {
font-family: inherit;
font-size: inherit;
font-weight: inherit;
line-height: inherit;
letter-spacing: inherit;
text-transform: inherit;
text-decoration: inherit;
word-spacing: inherit;
background: none;
border: none;
color: inherit;
padding: var(--wp--preset--spacing--20, 1em) 0;
cursor: pointer;
outline: none;
display: flex;
align-items: center;
text-align: inherit;
position: relative;
width: 100%;
}

.accordion-item__toggle > span {
width: 100%;
}
.accordion-item__toggle > span {
width: 100%;
}

.is-layout-flow > .wp-block-accordion-content,
.wp-block-accordion-content {
overflow: hidden;
margin: 0;
}
.is-layout-flow > .wp-block-accordion-content,
.wp-block-accordion-content {
overflow: hidden;
margin: 0;
}

.accordion-content__wrapper {
padding-bottom: var(--wp--preset--spacing--20, 1em);
}

/* No icon block style */
.is-style-no-icon .accordion-item__toggle-icon {
background-color: unset;
}
/* No icon block style */
.is-style-no-icon .accordion-item__toggle-icon {
background-color: unset;
}

.wp-block-accordion-trigger.icon-position-left .accordion-item__toggle {
/* stylelint-disable-next-line declaration-property-value-allowed-list -- This should be refactored to not use the row-reverse value. */
flex-direction: row-reverse;
}
.wp-block-accordion-trigger.icon-position-left .accordion-item__toggle {
/* stylelint-disable-next-line declaration-property-value-allowed-list -- This should be refactored to not use the row-reverse value. */
flex-direction: row-reverse;
}

.accordion-item__toggle:focus-visible {
outline: 2px solid -webkit-focus-ring-color;
outline-offset: 2px;
}
.accordion-item__toggle:focus-visible {
outline: 2px solid -webkit-focus-ring-color;
outline-offset: 2px;
}

/* Add transitions only for users who do not prefer reduced motion */
@media (prefers-reduced-motion: no-preference) {
.wp-block-accordion-item .accordion-item__toggle-icon {
transition: transform 0.2s ease-in-out;
}
/* Add transitions only for users who do not prefer reduced motion */
@media (prefers-reduced-motion: no-preference) {
.wp-block-accordion-item .accordion-item__toggle-icon {
transition: transform 0.2s ease-in-out;
}

.wp-block-accordion-item {
transition: grid-template-rows 0.3s ease-out;
}
.wp-block-accordion-item {
transition: grid-template-rows 0.3s ease-out;
}
}

.is-open {
.accordion-item__toggle-icon.has-icon-plus {
transform: rotate(45deg);
}
.accordion-item__toggle-icon.has-icon-chevron {
transform: rotate(-180deg);
}
.accordion-item__toggle-icon.has-icon-circlePlus {
transform: rotate(45deg);
}
.accordion-item__toggle-icon.has-icon-caret {
transform: rotate(-180deg);
}
.accordion-item__toggle-icon.has-icon-chevronRight {
transform: rotate(90deg);
}
.is-open {
.accordion-item__toggle-icon.has-icon-plus {
transform: rotate(45deg);
}
.accordion-item__toggle-icon.has-icon-chevron {
transform: rotate(-180deg);
}
.accordion-item__toggle-icon.has-icon-circlePlus {
transform: rotate(45deg);
}
.accordion-item__toggle-icon.has-icon-caret {
transform: rotate(-180deg);
}
.accordion-item__toggle-icon.has-icon-chevronRight {
transform: rotate(90deg);
}
}