Try: Enforce selected item icon colors on autocomplete. #64263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +22 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Aug 5, 2024
Contributor
There was a problem hiding this comment.
This approach makes sense to me.
I think the key point is whether color forcing should be introduced into Autocomplete component itself in the components package, or applied to the autocomplete component in the block-editor package.
This PR forces color on the former, but if we want to force color on the latter, we can merge #61376.
cc @WordPress/gutenberg-components
Contributor
Author
|
Closing in favor of #61376. Edit: and thank you all for looking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Plugins sometimes provide a spot color for block icons. This is fine, but in this auto-complete it means a lack of contrast:
This PR enforces the highlight color, overriding a plugin supplied color:
Why?
This ensures color contrast, while still affording plugin icon colors.
Testing Instructions
Install the Jetpack plugin. Then in any editor use the slash command to earch for a Jetpack block, such as
/pay. Observe sufficient contrast still in the highlighted state.