Style engine: update type for getCSSValueFromRawStyle #64528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #64490
Use a generic type parameter
StyleValueto describe argument and return value ofgetCSSValueFromRawStyle().Props to @kevin940726
Why?
Avoid the use of
anyand describe better what the function expects.How?
By default,
StyleValueis set to string. This allows the function to be flexible with the type of styleValue, but it defaults to handling strings.getCSSValueFromRawStyle()takes one parameter,styleValue, which is of typeStyleValue = string. This means it can be any type, but the function is primarily designed to work with strings.getCSSValueFromRawStyle()returns a value of the same typeStyleValue. This ensures that its output type matches its input type.Testing Instructions
The CI should build, all tests should pass.