-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Writing Flow: Collapse range in horizontal edge check by selection direction #6467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
654eb22
Writing Flow: Collapse range in horizontal edge check by direction
aduth f7dcc8a
Try alternative approach
ellatrix bef44c3
Writing Flow: Move collapsed selection condition to WritingFlow
aduth a8728bf
Writing Flow: Vertical navigate from uncollapsed selections
aduth 79fc388
Writing Flow: Use Selection#isCollapsed in place of hasCollapsedSelec…
aduth 83d3ff7
Rich Text: Verify collapsed selection in delete behavior
aduth 33184f9
Utils: Improve range rect detection for br-separated content
aduth f2ae9ef
Testing: Add Writing Flow E2E tests
aduth d81ac98
Try getRectangleFromRange fix without manipulating live DOM
ellatrix 284900e
Utils: Update caret to selection in edge tests comments
aduth bc252af
Writing Flow: Invert position when isReverse not aligned to backward
aduth a961282
Try direct selection
ellatrix 6431770
Only look at focusNode
ellatrix c0a0fc3
Utils: Document horizontal edge focusOffset
aduth b5a54df
Utils: Use temporary text node for rect fallback
aduth e087ddd
Writing Flow: Test horizontal navigation as handled
aduth 7b174ad
Element: Fix Fragment render error on empty children
aduth a528868
Testing: Add global guard against ZWSP in E2E content retrieval
aduth d6f1ab9
RichText: Remove ZWSP on focusout
aduth 4523390
RichText: Consider emptiness by Children count utility
aduth 31596df
Writing Flow: Consider horizontal handled by stopPropagation in RichText
aduth fa4ad6d
RichText: Get content by converting tree node to element
aduth 2afb649
Writing Flow: Consider as edge by effective caret position
aduth dab93de
Rich Text: Return element fragment as array
aduth 9dde841
Testing: Attempt to resolve race conditions with TinyMCE initialization
aduth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Utils: Use temporary text node for rect fallback
- Loading branch information
commit b5a54df3ed0907f7ba87b844b6a2ea25c05c0509
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this works for all cases in your testing, then cool, let's do it like this and I'll ponder there could be any better solution.