Skip to content

Improve Social Icons setup and appending #64877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeryj merged 8 commits into from
Aug 29, 2024
Merged

Improve Social Icons setup and appending #64877

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2daec6d
Remove “Click now” and use custom appender
getdave Aug 28, 2024
3ffbfaa
Adjust appender to match icon size setting
getdave Aug 28, 2024
c3d40c2
Show appender if self or any child is selected
getdave Aug 28, 2024
709ef45
Use recommended CSS
getdave Aug 29, 2024
9c043e0
Temp disable lint rule
getdave Aug 29, 2024
79703bd
Use existing selectors to detect any selected
getdave Aug 29, 2024
34a239c
Fix “jumping” when selecting block
getdave Aug 29, 2024
a1b2a22
Restore inserter button focus onclose
getdave Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust appender to match icon size setting
  • Loading branch information
@getdave
getdave committed Aug 28, 2024
commit 3ffbfaa5720c9d266e1a4d03b89268cc2592f471
21 changes: 16 additions & 5 deletions packages/block-library/src/social-links/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
// Editor specific styles for Social Links.
.wp-block-social-links {
div.block-editor-url-input {
display: inline-block;
margin-left: $grid-unit-10;
}
.wp-block-social-links div.block-editor-url-input {
display: inline-block;
margin-left: $grid-unit-10;
}


// Prevent toolbar from jumping when selecting / hovering a link.
.wp-social-link:hover {
transform: none;
Expand Down Expand Up @@ -106,3 +105,15 @@
padding: $grid-unit-10;
}
}

.wp-block-social-links {
&.has-small-icon-size .block-editor-button-block-appender.components-button.components-button {
padding: $grid-unit-10 / 2;
}
&.has-large-icon-size .block-editor-button-block-appender.components-button.components-button {
padding: $grid-unit-20;
}
&.has-huge-icon-size .block-editor-button-block-appender.components-button.components-button {
padding: $grid-unit-30;
}
}