Skip to content

Fix grid layout padding on small screens #64878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameskoster merged 5 commits into from
Sep 20, 2024
Merged

Fix grid layout padding on small screens #64878

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a77fe42
Fix grid layout padding on small screens
jameskoster Aug 28, 2024
bed85b9
Merge branch 'trunk' into fix/grid-layout-small-screens
jameskoster Aug 29, 2024
888f6f0
Merge branch 'trunk' into fix/grid-layout-small-screens
jameskoster Sep 13, 2024
0483220
Merge branch 'trunk' into fix/grid-layout-small-screens
jameskoster Sep 13, 2024
9960226
Merge branch 'trunk' into fix/grid-layout-small-screens
jameskoster Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/dataviews/src/components/dataviews/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@
padding: $grid-unit-15 $grid-unit-30;
}

.dataviews-view-grid,
.dataviews-no-results,
.dataviews-loading {
padding-left: $grid-unit-30;
Expand Down
8 changes: 8 additions & 0 deletions packages/dataviews/src/dataviews-layouts/grid/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,3 +163,11 @@
.dataviews-view-grid__card.is-selected .dataviews-selection-checkbox {
top: $grid-unit-10;
}

/* stylelint-disable-next-line scss/at-rule-no-unknown -- '@container' not globally permitted */
@container (max-width: 430px) {
Copy link
Contributor

@jasmussen jasmussen Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR as a whole works for me. But this is new! I wonder:

  • Should we have a system for these widths? Some variables we define and then use, just like we have modal preset sizes, so arbitrary fix-widths don't propogate?
  • Do we need a fallback? Support is generally good, so probably not, but worth pondering.

Copy link
Contributor Author

@jameskoster jameskoster Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially yes. Another approach would be to restructure the Page component a bit so that the behavior is built into the region that displays page content, with props to disable. That is a bigger discussion.

.dataviews-view-grid {
padding-left: $grid-unit-30;
padding-right: $grid-unit-30;
}
}