Interactivity API: Improve internal deepMerge function#64879
Interactivity API: Improve internal deepMerge function#64879
deepMerge function#64879Conversation
luisherranz
left a comment
There was a problem hiding this comment.
This looks fantastic. Thanks, David! I know you haven't finished yet, but I'm going to approve it anyway.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for the review, @luisherranz! I've addressed your feedback and polished the code a bit. It should be ready now. 🙂 |
…4879) * Move deepMerge to proxies and update implementation * Remove Boolean casting in hasPropSignal implementation * Test subscriptions to nested props updates * Remove extraneous label * Check signals are not created for nested props * Fix getProxyFromObject types * Add missing imports * Add extra assertions to ensure correct signal creation * Do not expose hasPropSignal from proxies/index * Add missing TSDocs * Update changelog Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
What?
Improves the internal
deepMerge()function implementation. The main reason for these changes is to ensuredeepMerge()follows the following rules:Why?
Required by the upcoming
getServerState()andgetServerContext()functions to handle state updates from the server.How?
The new
deepMerge()implementation directly manipulates the objects behind state proxies. If an existing property value is updated, it checks whether a correspondingPropSignalinstance exists. Only in that case are the signal values updated.Testing Instructions
I added unit tests for the three rules mentioned above.