Skip to content

Improve Tabs indicator animation and related utils #64926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaniGuardiola merged 19 commits into from
Sep 11, 2024
Merged

Improve Tabs indicator animation and related utils #64926

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f5a833a
Refactor utils and switch Tabs indicator animation to `transform`.
DaniGuardiola Aug 30, 2024
42080a4
docs tweak
DaniGuardiola Aug 30, 2024
7377fc0
Update packages/components/src/tabs/styles.ts
DaniGuardiola Aug 30, 2024
405c258
Add RTL support.
DaniGuardiola Sep 2, 2024
4726e53
Addressed @ciampo's comments.
DaniGuardiola Sep 2, 2024
6835665
Correct for antialiasing rounding.
DaniGuardiola Sep 2, 2024
1e444af
Make antialiasing adjustment optional.
DaniGuardiola Sep 2, 2024
7861921
Use larger base value and revert antialiasing adjustment code.
DaniGuardiola Sep 2, 2024
55dd870
DRY RTL
DaniGuardiola Sep 2, 2024
d03622b
Remove RTL story (redundant since Storybook has a dynamic setting to …
DaniGuardiola Sep 2, 2024
c347fad
Fix bug.
DaniGuardiola Sep 2, 2024
59797e4
Fix bug (for real this time).
DaniGuardiola Sep 2, 2024
f82b413
Add changelog entry.
DaniGuardiola Sep 2, 2024
4db2b35
De-cleverfy code.
DaniGuardiola Sep 2, 2024
e36a506
Sync useResizeObserver with #64943 and make useTrackElementOffsetRect…
DaniGuardiola Sep 8, 2024
b57955b
Merge branch 'trunk' of https://github.com/WordPress/gutenberg into i…
DaniGuardiola Sep 10, 2024
bc62400
Deduplicate utility and clean up.
DaniGuardiola Sep 10, 2024
3f6a381
DRY antialiasing factor.
DaniGuardiola Sep 11, 2024
522d816
Changelogs.
DaniGuardiola Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Changelogs.
  • Loading branch information
@DaniGuardiola
DaniGuardiola committed Sep 11, 2024
commit 522d816c2d808c12cd776802ab0369a39ec003be
6 changes: 5 additions & 1 deletion packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Bug Fixes

- `Tabs`: indicator positioning under RTL direction ([#64926](https://github.com/WordPress/gutenberg/pull/64926)).

### Deprecations

- Deprecate `__unstableComposite`, `__unstableCompositeGroup`, `__unstableCompositeItem` and `__unstableUseCompositeState`. Consumers of the package should use the stable `Composite` component instead ([#63572](https://github.com/WordPress/gutenberg/pull/63572)).
Expand All @@ -12,6 +16,7 @@

### Internal

- `Tabs`: improved performance of the indicator animation ([#64926](https://github.com/WordPress/gutenberg/pull/64926)).
- `Composite`: Remove from private APIs ([#63569](https://github.com/WordPress/gutenberg/pull/63569)).
- use local copy of `use-lilius` instead of `npm` dependency ([#65097](https://github.com/WordPress/gutenberg/pull/65097)).

Expand Down Expand Up @@ -77,7 +82,6 @@

### Bug Fixes

- `Tabs`: indicator positioning under RTL direction ([#64926](https://github.com/WordPress/gutenberg/pull/64926)).
- `TimePicker`: use ToggleGroupControl for AM/PM toggle ([#64800](https://github.com/WordPress/gutenberg/pull/64800)).
- `ColorPalette` utils: do not normalize undefined color values ([#64969](https://github.com/WordPress/gutenberg/pull/64969)).
- `DatePicker` restore round radius for event dot ([#65031](https://github.com/WordPress/gutenberg/pull/65031)).
Expand Down