Skip to content

Patterns: add opt out preference to the 'Choose a Pattern' modal when adding a page #65026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonjd merged 8 commits into from
Sep 8, 2024
Merged

Patterns: add opt out preference to the 'Choose a Pattern' modal when adding a page #65026

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bc39750
Adds a preference to disable the loading of the Choose a pattern moda…
ramonjd Sep 4, 2024
48fabd8
Return an empty array from the memoized value of useStartPatterns() s…
ramonjd Sep 4, 2024
c3e41ab
Don't reset the `isClosed` value in the same editor session. This pre…
ramonjd Sep 4, 2024
01552df
Move preferences toggle to Publishing
ramonjd Sep 6, 2024
f91c964
Move preferences toggle to Publishing (in the right place now)
ramonjd Sep 6, 2024
8799cd3
Revert styles for modal footer
ramonjd Sep 6, 2024
0512af8
Move pref to interface group and coerce bool
ramonjd Sep 6, 2024
613b197
Only memo hasStarterPatterns
ramonjd Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move pref to interface group and coerce bool
  • Loading branch information
@ramonjd
ramonjd committed Sep 6, 2024
commit 0512af881101e5e2ffbdaae8037000c474626e31
22 changes: 10 additions & 12 deletions packages/editor/src/components/preferences-modal/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,18 +154,6 @@ export default function EditorPreferencesModal( { extraSections = {} } ) {
'Enable pre-publish checks'
) }
/>
{ starterPatterns?.length && (
<PreferenceToggleControl
scope="core"
featureName="enableChoosePatternModal"
help={ __(
'Shows starter patterns when creating a new page.'
) }
label={ __(
'Show starter patterns'
) }
/>
) }
</PreferencesModalSection>
) }
{ extraSections?.general }
Expand Down Expand Up @@ -259,6 +247,16 @@ export default function EditorPreferencesModal( { extraSections = {} } ) {
'Show text instead of icons on buttons across the interface.'
) }
/>
{ !! starterPatterns?.length && (
<PreferenceToggleControl
scope="core"
featureName="enableChoosePatternModal"
help={ __(
'Shows starter patterns when creating a new page.'
) }
label={ __( 'Show starter patterns' ) }
/>
) }
</PreferencesModalSection>
</>
),
Expand Down