Add: Typography styling support to the navigation submenu block. #65060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Thanks so much for the quick work here! Tested this and can confirm it works (keep styling of parent menu and applies it to submenu): style.menu.and.submenu.mov |
jorgefilipecosta
added
the
Needs Technical Feedback
jorgefilipecosta
requested review from
fabiankaegy,
juanmaguitar and
ndiego
as code owners
jorgefilipecosta
force-pushed
the
add/equivalent-navigation-link-styles-to-the-navigation-submenu-block
branch
from
e1ff48d to
42bd8c1
Compare
Mamaduka
approved these changes
Sep 13, 2024
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
This looks good and matches similar settings for other blocks.
jorgefilipecosta
deleted the
add/equivalent-navigation-link-styles-to-the-navigation-submenu-block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #49319
Currently, the navigation submenu block does not support typography styles, while the navigation link block supports them.
This has several issues:
This PR adds the same typography styles supported in the navigation link to the navigation submenu block.
cc: @cuemarie, @annezazu
Testing Instructions
I added a navigation submenu and verified I could change its typography. The styles are applied on both the frontend and the editor.
I added a navigation link with some typography styles. I transformed that link into a submenu and verified the styles were kept (on the trunk they are discarded).