Skip to content

Global Styles: allow read access to users with edit_posts capabilities #65071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonjd merged 17 commits into from
Sep 18, 2024
Merged

Global Styles: allow read access to users with edit_posts capabilities #65071

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
317bcd9
Allow base global styles data in post editor
aaronrobertshaw Aug 26, 2024
817381f
Try getting user global styles working
aaronrobertshaw Aug 26, 2024
f2ce2c7
Remove placeholder code
aaronrobertshaw Aug 28, 2024
935aa3e
Reinstate default context for globalStyles in entities.js
ramonjd Sep 5, 2024
9ee89e3
A test to allow view context for global styles GET request
ramonjd Sep 5, 2024
3c86530
Now that Star Wars is owned by Disney, do we still need Yoda conditions?
ramonjd Sep 9, 2024
499bf2d
Added permissions test for editor role
ramonjd Sep 9, 2024
2ce6ba9
Allow reading base theme global styles in all instances
ramonjd Sep 12, 2024
db62b62
Whoops. Should be "update"
ramonjd Sep 12, 2024
f35d9b0
Return value on new filter
ramonjd Sep 12, 2024
16772a3
Update return annotation
ramonjd Sep 12, 2024
eac8ee2
Backport changelog entry
ramonjd Sep 12, 2024
801883f
remove preload path filtering
ramonjd Sep 17, 2024
24e5786
Add view context preload fetch for global styles.
ramonjd Sep 17, 2024
8caa9f5
revert preload until we work out how to preload
ramonjd Sep 17, 2024
768770e
Reinstate `edit_theme_options` check and add test coverage
ramonjd Sep 18, 2024
8d99a26
LINT ME LIKE YOU MEAN IT
ramonjd Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove placeholder code
  • Loading branch information
@aaronrobertshaw @ramonjd
aaronrobertshaw authored and ramonjd committed Sep 18, 2024
commit f2ce2c769cd2eb67873d6cc98ef77ca56a208e5b
11 changes: 0 additions & 11 deletions packages/core-data/src/entities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,17 +190,6 @@ export const rootEntitiesConfig = [
revisionId ? '/' + revisionId : ''
}`,
supportsPagination: true,
getPath: ( path, query, baseURL, id ) => {
const context =
query.context ||
( query.operation === 'read' ? 'view' : 'edit' );
const contextQuery = context ? `?context=${ context }` : '';
return `${ baseURL }${ id ? '/' + id : '' }${ contextQuery }`;
},
capabilities: {
read: 'edit_posts',
update: 'edit_theme_options',
},
},
{
label: __( 'Themes' ),
Expand Down