A11y: Add script-module #65101
Merged
A11y: Add script-module #65101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +972 B (+0.06%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
sirreal
force-pushed
the
add-a11y-script-module
branch
from
4f389e8 to
0c132f6
Compare
This was referenced Sep 5, 2024
afercia
added
[Focus] Accessibility (a11y)
This was referenced Sep 10, 2024
sirreal
force-pushed
the
add-a11y-script-module
branch
3 times, most recently
from
84b7339 to
b6256a4
Compare
sirreal
force-pushed
the
update/script-modules-build
branch
from
7c7702a to
5bf5899
Compare
sirreal
force-pushed
the
add-a11y-script-module
branch
2 times, most recently
from
4dd71f6 to
a79ceda
Compare
sirreal
commented
Sep 11, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
commented
Sep 11, 2024
gziolo
reviewed
Sep 12, 2024
gziolo
reviewed
Sep 12, 2024
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
It's nice to see how two versions of the same package land in the corresponding build folders
Script with wp globals and script dependencies
Script module with no dependencies
From my perspective, it's nearly ready. There are only nitpicks to address.
lib/experimental/script-modules.php
Outdated
| add_filter( | ||
| 'script_module_data_@wordpress/a11y', | ||
| function ( $data ) { | ||
| $data['i18n'] = array( 'Notifications' => __( 'Notifications' ) ); |
Member
There was a problem hiding this comment.
For the record, the same feedback applies as the one shared by @swissspidy in #65123 (comment). I echo that this is really a step backwards from the JS I18N mechanism we implemented all those years ago. However, I hope we can address that with the next planned steps when we replicate the same approach for @wordpress/i18n as for the @wordpress/a11y package.
Member
|
Coding standards CI job for PHP insists on the domain 🙈: 
Otherwise, it's good to go from my perspective. So great to see how these pieces start to fit together 🎉 |
gziolo
approved these changes
Sep 12, 2024
|
Flaky tests detected in 1b86c49. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10828924375
|
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a
@wordpress/a11yWordPress Script Module. The script module has the same public API as thewp-a11yscript.domReadypackage should not be necessary. Since modules are deferred,setupcan be called directly when the module is evaluated.i18nscript module at this time. The necessary string "Notifications" is translated on the server and passed to the package via script module data.Most of the changes here are moving some functions around so that the script and the module form of this package rely on the same underlying implementations.
This is useful for the Interactivity Router and other work such as #62906.
Depends on #65064
Related PRs:
Testing Instructions
This is unused at the moment in Gutenberg, but can be tested by other packages. #65123 uses the a11y script module in the interactivity-router package. The behavior can be demonstrated there, for example via the playground.