Plugin: Remove 'function_exists' checks for methods with 'gutenberg' prefix #65260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
Gutenberg Plugin
Mamaduka
requested review from
aaronrobertshaw,
jorgefilipecosta and
ramonjd
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
the
No Core Sync Required
ramonjd
approved these changes
Sep 12, 2024
Member
There was a problem hiding this comment.
LGTM
I can't remember if this phpcs rule catches these or not.
I think that's the reason behind all the function_exists, could be wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR removes
function_existschecks for functions with thegutenbergprefix. These are plugin methods, and there should be no duplicates.I also moved
gutenberg_register_wp_rest_post_types_controller_fieldsinto the correct compat files. The bugfix was merged in WP 6.6. See #62488.Testing Instructions