Skip to content

DEWP: Handle cyclical module dependencies #65291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalczaplinski merged 11 commits into from
Sep 19, 2024
Merged

DEWP: Handle cyclical module dependencies #65291

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
edb8889
Add tests for cyclical dependencies
michalczaplinski Sep 12, 2024
67d0676
Add the externals and make the test fail
michalczaplinski Sep 16, 2024
8fd700f
Add cycle detection in dependency path checking
michalczaplinski Sep 16, 2024
5654813
Revert changes
sirreal Sep 16, 2024
b19c3e0
Propose static WeakSet/WeakMap implementation.
sirreal Sep 16, 2024
3f8f2f4
Add CHANGELOG entry
sirreal Sep 16, 2024
b5e33db
Remove redundant plugin config in test
sirreal Sep 16, 2024
44d6968
Revert "Remove redundant plugin config in test"
sirreal Sep 16, 2024
0c2de0d
Remove redundant plugin config in test
sirreal Sep 16, 2024
81d15af
Updated the snapshot files
michalczaplinski Sep 18, 2024
8a0eabb
Merge remote-tracking branch 'origin/trunk' into fix/dewp-cyclical-deps
michalczaplinski Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add tests for cyclical dependencies
  • Loading branch information
@michalczaplinski
michalczaplinski committed Sep 12, 2024
commit edb8889dce54e31e8aadd9259bd39031bd1c493b
14 changes: 14 additions & 0 deletions packages/dependency-extraction-webpack-plugin/test/__snapshots__/build.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,13 @@ exports[`DependencyExtractionWebpackPlugin modules Webpack \`cyclic-dependency-g
]
`;

exports[`DependencyExtractionWebpackPlugin modules Webpack \`cyclic-deps\` should produce expected output: Asset file 'main.asset.php' should match snapshot 1`] = `
"<?php return array('dependencies' => array(), 'version' => '659ee86bae9fb389a844', 'type' => 'module');
"
`;

exports[`DependencyExtractionWebpackPlugin modules Webpack \`cyclic-deps\` should produce expected output: External modules should match snapshot 1`] = `[]`;

exports[`DependencyExtractionWebpackPlugin modules Webpack \`cyclic-dynamic-dependency-graph\` should produce expected output: Asset file 'main.asset.php' should match snapshot 1`] = `
"<?php return array('dependencies' => array(array('id' => '@wordpress/interactivity', 'import' => 'dynamic')), 'version' => '293aebad4ca761cf396f', 'type' => 'module');
"
Expand Down Expand Up @@ -394,6 +401,13 @@ exports[`DependencyExtractionWebpackPlugin scripts Webpack \`cyclic-dependency-g
]
`;

exports[`DependencyExtractionWebpackPlugin scripts Webpack \`cyclic-deps\` should produce expected output: Asset file 'main.asset.php' should match snapshot 1`] = `
"<?php return array('dependencies' => array(), 'version' => '174bed1cc91890a295ff');
"
`;

exports[`DependencyExtractionWebpackPlugin scripts Webpack \`cyclic-deps\` should produce expected output: External modules should match snapshot 1`] = `[]`;

exports[`DependencyExtractionWebpackPlugin scripts Webpack \`cyclic-dynamic-dependency-graph\` should produce expected output: Asset file 'main.asset.php' should match snapshot 1`] = `
"<?php return array('dependencies' => array('wp-interactivity'), 'version' => 'ac0e2f1bcd3a6a0e7aff');
"
Expand Down
8 changes: 8 additions & 0 deletions packages/dependency-extraction-webpack-plugin/test/fixtures/cyclic-deps/a.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/**
* Internal dependencies
*/
import { someFunction } from '.';

someFunction();

export const a = 'test';
8 changes: 8 additions & 0 deletions packages/dependency-extraction-webpack-plugin/test/fixtures/cyclic-deps/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/**
* Internal dependencies
*/
import { a } from './a';

export const someFunction = () => {
return a;
};
8 changes: 8 additions & 0 deletions packages/dependency-extraction-webpack-plugin/test/fixtures/cyclic-deps/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/**
* Internal dependencies
*/
const DependencyExtractionWebpackPlugin = require( '../../..' );

module.exports = {
plugins: [ new DependencyExtractionWebpackPlugin() ],
Copy link
Member

@sirreal sirreal Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there will need to be an external module listed here that's used in one or both of the file and we can probably disable defaults as well.

Copy link
Contributor Author

@michalczaplinski michalczaplinski Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jon! Yeah, I've added it now!

I think I didn't realize this before: The problem that I found only affects the externalized modules. Do you think that's correct?

};