Skip to content

Packages: only add polyfills where needed #65292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgomes merged 14 commits into from
Sep 18, 2024
Merged

Packages: only add polyfills where needed #65292

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f0e3386
Packages: only add polyfills where needed
sgomes Sep 12, 2024
9a490fc
Attempt to fix interactivity-router
sgomes Sep 12, 2024
9d54993
Switch to using magic comments
sgomes Sep 13, 2024
74bab7c
Remove previous experiment
sgomes Sep 13, 2024
1f7785b
Clean up changelog, comments and option name
sgomes Sep 13, 2024
5e926d3
Fix small typo in babel plugin comment
sgomes Sep 13, 2024
0d03c67
Tweak comment preservation regex
sgomes Sep 13, 2024
a3d11f1
Simplify buffer check
sgomes Sep 17, 2024
a1b0480
Fix outdated comment
sgomes Sep 17, 2024
5a51225
Use Internal header for babel preset changelog
sgomes Sep 17, 2024
d9ea190
Add unit test for DEWP
sgomes Sep 17, 2024
061b7eb
Add babel plugin test
sgomes Sep 18, 2024
91eb78d
Update babel plugin readme
sgomes Sep 18, 2024
28f1b5b
Simplify DEWP test
sgomes Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Attempt to fix interactivity-router
  • Loading branch information
@sgomes
sgomes committed Sep 18, 2024
commit 9a490fc99f743e9b1ab5fd036f4790df2359bf92
10 changes: 10 additions & 0 deletions packages/dependency-extraction-webpack-plugin/lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,16 @@ class DependencyExtractionWebpackPlugin {
}

if ( externalRequest ) {
// Special case for modules.
// Since `@wordpress/polyfill` is a script and not a module, we need
// to exclude it from the list of externalised deps.
if (
this.useModules &&
externalRequest.includes( '@wordpress/polyfill' )
) {
return callback( null, '' );
Copy link
Member

@sirreal sirreal Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this attempting to ignore the module during when externalizing?

Copy link
Contributor Author

@sgomes sgomes Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct! I sneaked this change in today to see if it fixed the tests. If it works, I'll see if I can simplify it later 🙂

Copy link
Member

@gziolo gziolo Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it would be necessary to be included somehow for @wordpress/interactivity-router.

Copy link
Contributor Author

@sgomes sgomes Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I think this exposed the fact that while @wordpress/interactivity-router doesn't currently depend on the polyfills, it probably should, if we want it to work correctly in older browsers like Chrome 109. Although there isn't really a good mechanism to make that happen, as far as I know 🤔

}

this.externalizedDeps.add( request );

return callback( null, externalRequest );
Expand Down