Skip to content

Fix: Button: Replace remaining 40px default size violation [Edit Site 3] #65309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 5 commits into from
Sep 25, 2024
Merged

Fix: Button: Replace remaining 40px default size violation [Edit Site 3] #65309

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9b6c3f
Fix patterns link button title to use 40px default size
hbhalodia Sep 13, 2024
744b937
Fix open save panel button default size to 40px
hbhalodia Sep 13, 2024
752d3a2
Fix editor sidebar buttons to use 40px defualt size
hbhalodia Sep 13, 2024
2cc7851
Fix data views create new views buttons to use 40px default size
hbhalodia Sep 13, 2024
b9ab536
Fix site hub buttons to use 40px default button size
hbhalodia Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix data views create new views buttons to use 40px default size
  • Loading branch information
@hbhalodia @mirka
hbhalodia authored and mirka committed Sep 25, 2024
commit 2cc7851acd603e3f5acc62c0d6eea853d62544c7
6 changes: 2 additions & 4 deletions packages/edit-site/src/components/sidebar-dataviews/add-new-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,7 @@ function AddNewItemModalContent( { type, setIsAdding } ) {
/>
<HStack justify="right">
<Button
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
__next40pxDefaultSize
Copy link
Contributor Author

@hbhalodia hbhalodia Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be seen when you add a custom data view and click on add new.

Before After
View-before view-after

variant="tertiary"
onClick={ () => {
setIsAdding( false );
Expand All @@ -99,8 +98,7 @@ function AddNewItemModalContent( { type, setIsAdding } ) {
</Button>

<Button
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
__next40pxDefaultSize
Copy link
Contributor Author

@hbhalodia hbhalodia Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be seen when you add a custom data view and click on add new.

Before After
View-before view-after

variant="primary"
type="submit"
aria-disabled={ ! title || isSaving }
Expand Down