Skip to content

Conversation

@DaniGuardiola
Copy link
Member

@DaniGuardiola DaniGuardiola commented Sep 17, 2024

What?

Fix a regressiong that caused the vertical indicator to disappear.

How?

It was a typo. My bad!

Testing Instructions

Try vertical tabs in the Storybook.

Screenshots or screencast

Before:

{951FD2C5-919D-4150-A7DE-382BDF31FFCA}

After:

{F2625813-1207-4161-A204-7887C6B78161}

@DaniGuardiola DaniGuardiola requested a review from a team September 17, 2024 05:30
@github-actions
Copy link

github-actions bot commented Sep 17, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: DaniGuardiola <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@DaniGuardiola DaniGuardiola added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Sep 17, 2024
@DaniGuardiola DaniGuardiola self-assigned this Sep 17, 2024
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix 👍

BTW it's always useful to link to where this regressed. In this case, it was in #64926.

@tyxla tyxla enabled auto-merge (squash) September 17, 2024 11:32
@tyxla tyxla merged commit afbb659 into trunk Sep 17, 2024
@tyxla tyxla deleted the fix/vertical-tabs-indicator branch September 17, 2024 11:48
@github-actions github-actions bot added this to the Gutenberg 19.3 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants