-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix useResizeObserver bugs
#65389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix useResizeObserver bugs
#65389
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
160cb5b
Rename "_legacy" dir to "legacy"
DaniGuardiola 35153bf
Fix circular dependency issue
DaniGuardiola 008893b
Fix bug that caused elements to not be unobserved.
DaniGuardiola 776cabf
Add changelog
DaniGuardiola da96a81
Remove changelog entry
DaniGuardiola File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
43 changes: 43 additions & 0 deletions
43
packages/compose/src/hooks/use-resize-observer/use-resize-observer.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { useRef } from '@wordpress/element'; | ||
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import useEvent from '../use-event'; | ||
|
|
||
| // This is the current implementation of `useResizeObserver`. | ||
| // | ||
| // The legacy implementation is still supported for backwards compatibility. | ||
| // This is achieved by overloading the exported function with both signatures, | ||
| // and detecting which API is being used at runtime. | ||
| export function useResizeObserver< T extends HTMLElement >( | ||
| callback: ResizeObserverCallback, | ||
| resizeObserverOptions: ResizeObserverOptions = {} | ||
| ): ( element?: T | null ) => void { | ||
| const callbackEvent = useEvent( callback ); | ||
|
|
||
| const observedElementRef = useRef< T | null >(); | ||
| const resizeObserverRef = useRef< ResizeObserver >(); | ||
| return useEvent( ( element?: T | null ) => { | ||
| if ( element === observedElementRef.current ) { | ||
| return; | ||
| } | ||
|
|
||
| // Set up `ResizeObserver`. | ||
| resizeObserverRef.current ??= new ResizeObserver( callbackEvent ); | ||
| const { current: resizeObserver } = resizeObserverRef; | ||
|
|
||
| // Unobserve previous element. | ||
| if ( observedElementRef.current ) { | ||
| resizeObserver.unobserve( observedElementRef.current ); | ||
| } | ||
|
|
||
| // Observe new element. | ||
| observedElementRef.current = element; | ||
| if ( element ) { | ||
| resizeObserver.observe( element, resizeObserverOptions ); | ||
| } | ||
| } ); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.